Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost min/max validation #48

Closed
stdavis opened this issue Jul 14, 2022 · 3 comments · Fixed by #259
Closed

Cost min/max validation #48

stdavis opened this issue Jul 14, 2022 · 3 comments · Fixed by #259
Assignees
@stdavis

Comments

@stdavis
Copy link
Member

stdavis commented Jul 14, 2022

Add user validation feedback to make sure that min is less than max and vice versa.
@stdavis stdavis self-assigned this Jul 22, 2022
@msilski
Copy link
Contributor

msilski commented Jul 26, 2022

The validation works great. I see the error message is "max should be less than min" - can you change the message to "max should be greater than min" (or something similar)?

@stdavis
Copy link
Member Author

stdavis commented Jul 26, 2022

Doh! :) Here's a new release with the typo fixed: https://github.com/agrc/wfrc-rtp-projects/releases/tag/v1.2.1

@msilski
Copy link
Contributor

msilski commented Jul 26, 2022

No problem! Looks great now.

@ugrc-release-bot ugrc-release-bot bot mentioned this issue Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdavis stdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: release v5.3.6 agrc/wfrc-rtp-projects
2 participants
@stdavis @msilski