From 203a2b022062c2c16750aa8c93818a36655e983b Mon Sep 17 00:00:00 2001
From: stdavis <stdavis@utah.gov>
Date: Wed, 30 Oct 2024 14:06:21 -0600
Subject: [PATCH] docs: make it clear that you can pass a project id or alias

---
 .vscode/settings.json |  6 ++++++
 action.yml            | 18 +++++++++---------
 2 files changed, 15 insertions(+), 9 deletions(-)
 create mode 100644 .vscode/settings.json

diff --git a/.vscode/settings.json b/.vscode/settings.json
new file mode 100644
index 0000000..a1a8699
--- /dev/null
+++ b/.vscode/settings.json
@@ -0,0 +1,6 @@
+{
+  "cSpell.words": [
+    "prebuild",
+    "worknote"
+  ]
+}
diff --git a/action.yml b/action.yml
index 0d02fe5..1f366d7 100644
--- a/action.yml
+++ b/action.yml
@@ -8,7 +8,7 @@ inputs:
     description: Service Account Email
     required: true
   project-id:
-    description: Project ID
+    description: Project ID or alias. This also sets the firebase environment (https://firebase.google.com/docs/functions/config-env).
     required: true
   preview:
     description: Determines if firebase deploys to a preview channel
@@ -71,7 +71,7 @@ runs:
         create_credentials_file: true
 
     - name: 🍳 Run prebuild command
-      if: ${{ inputs.prebuild-command != '' }}
+      if: inputs.prebuild-command != ''
       shell: bash
       run: ${{ inputs.prebuild-command }}
 
@@ -88,6 +88,12 @@ runs:
           ${{ runner.OS }}-bower-
           ${{ runner.OS }}
 
+    - name: ❓ Determining if preview should be created
+      id: should-create-preview
+      if: inputs.preview == 'yes'
+      shell: bash
+      run: echo "deploy=yes" >> $GITHUB_OUTPUT
+
     - name: 🪣 Cache firebase
       uses: actions/cache@v4
       with:
@@ -97,12 +103,6 @@ runs:
           ${{ runner.OS }}-firebase-
           ${{ runner.OS }}-
 
-    - name: ❓ Determining if preview should be created
-      id: should-create-preview
-      if: inputs.preview == 'yes'
-      shell: bash
-      run: echo "deploy=yes" >> $GITHUB_OUTPUT
-
     - name: 🚀 Firebase deploy preview
       id: deploy
       if: steps.should-create-preview.outputs.deploy == 'yes'
@@ -124,7 +124,7 @@ runs:
 
     - name: 🔔 Publish deployment worknote
       uses: agrc/service-now-worknote-action@v1
-      if: ${{ inputs.service-now-system-id != '' && inputs.preview != 'yes' }}
+      if: inputs.service-now-system-id != '' && inputs.preview != 'yes'
       with:
         repo-token: ${{ inputs.repo-token }}
         username: ${{ inputs.service-now-username }}