Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostnames don't change on Provision #143

Open
benyanke opened this issue Sep 1, 2017 · 1 comment
Open

Hostnames don't change on Provision #143

benyanke opened this issue Sep 1, 2017 · 1 comment
Labels
bug wontfix

Comments

@benyanke
Copy link

benyanke commented Sep 1, 2017

Given the following workflow, the hostnames are not correctly updated.

  • vagrant up with hostnames: 1.1.1.1 -> olddomain.com
  • Edit vagrantfile to specify 1.1.1.1 -> newdomain.com
  • vagrant destroy -f ; vagrant up

In this circumstance, the plugin simply reports "found entry" instead of correctly deleting and replacing, leaving the olddomain.com in the hosts file, and not applying newdomain.com to the hosts file.
@cgsmith
Copy link
Collaborator

cgsmith commented Mar 30, 2018

@benyanke thanks for the bug report - I will test it out locally and come up with a fix. PRs welcome!

@cgsmith cgsmith added the bug label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgsmith @benyanke