From ccdc0154a5be41d345b9ed118000e31c38e77c25 Mon Sep 17 00:00:00 2001 From: Martin Vidner Date: Tue, 22 Aug 2023 14:58:10 +0200 Subject: [PATCH] Fix Unknown method: SetInteractive for `agama questions mode non-interactive` (#709) We want to access Interactive, a writable property. zbus-xmlgen generates a proxy for setting a writable property but forgets to mark it as a property, generating a method call instead --- rust/agama-dbus-server/src/network/nm/proxies.rs | 7 +++++++ rust/agama-lib/src/proxies.rs | 1 + 2 files changed, 8 insertions(+) diff --git a/rust/agama-dbus-server/src/network/nm/proxies.rs b/rust/agama-dbus-server/src/network/nm/proxies.rs index 32c3f0f833..8bfa6f43bb 100644 --- a/rust/agama-dbus-server/src/network/nm/proxies.rs +++ b/rust/agama-dbus-server/src/network/nm/proxies.rs @@ -162,6 +162,7 @@ trait NetworkManager { /// ConnectivityCheckEnabled property #[dbus_proxy(property)] fn connectivity_check_enabled(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_connectivity_check_enabled(&self, value: bool) -> zbus::Result<()>; /// ConnectivityCheckUri property @@ -177,6 +178,7 @@ trait NetworkManager { fn global_dns_configuration( &self, ) -> zbus::Result>; + #[dbus_proxy(property)] fn set_global_dns_configuration( &self, value: std::collections::HashMap<&str, zbus::zvariant::Value<'_>>, @@ -221,6 +223,7 @@ trait NetworkManager { /// WimaxEnabled property #[dbus_proxy(property)] fn wimax_enabled(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_wimax_enabled(&self, value: bool) -> zbus::Result<()>; /// WimaxHardwareEnabled property @@ -230,6 +233,7 @@ trait NetworkManager { /// WirelessEnabled property #[dbus_proxy(property)] fn wireless_enabled(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_wireless_enabled(&self, value: bool) -> zbus::Result<()>; /// WirelessHardwareEnabled property @@ -239,6 +243,7 @@ trait NetworkManager { /// WwanEnabled property #[dbus_proxy(property)] fn wwan_enabled(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_wwan_enabled(&self, value: bool) -> zbus::Result<()>; /// WwanHardwareEnabled property @@ -291,6 +296,7 @@ trait Device { /// Autoconnect property #[dbus_proxy(property)] fn autoconnect(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_autoconnect(&self, value: bool) -> zbus::Result<()>; /// AvailableConnections property @@ -374,6 +380,7 @@ trait Device { /// Managed property #[dbus_proxy(property)] fn managed(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_managed(&self, value: bool) -> zbus::Result<()>; /// Metered property diff --git a/rust/agama-lib/src/proxies.rs b/rust/agama-lib/src/proxies.rs index 9d6371eac0..a196ff1876 100644 --- a/rust/agama-lib/src/proxies.rs +++ b/rust/agama-lib/src/proxies.rs @@ -147,5 +147,6 @@ trait Questions1 { /// Interactive property #[dbus_proxy(property)] fn interactive(&self) -> zbus::Result; + #[dbus_proxy(property)] fn set_interactive(&self, value: bool) -> zbus::Result<()>; }