feat: Contract read & write #872

janmichek · 2024-07-31T13:35:34Z

Description

resolves #254
resolves #256

Demo

firefox_jVaQW0PNfH.mp4

Checklist:

I have read and followed the Contributing Guide
My change requires a change to the documentation.
I have updated the documentation accordingly.

github-actions · 2024-07-31T13:40:47Z

Deployed to https://pr-872-aescan.stg.service.aepps.com and https://pr-872-aescan-testnet.stg.service.aepps.com

janmichek · 2024-07-31T14:05:16Z

Testing notes for @Liubov-crypto

go to https://studio.aepps.com/ and deploy some contracts to testnet
do the verification in this PR preview on testnet. Select 7.4.0
go to verified contract detail, now you can access read actions
write actions cannot be verified, given the current limitations

janmichek · 2024-07-31T14:06:46Z

@Liubov-crypto And I found a way to test the write actions. Can you create new Superhero wallet account and send me the seed?

Liubov-crypto · 2024-08-08T11:06:30Z

I was getting an issue when tried to verify the smart contract.
For example I've used:
ct_svN4AGuUh2EJK4WfFQvY39Vpzd7awqmEZiFMybNG9t9gaSp98

janmichek · 2024-08-12T10:52:37Z

I was getting an issue when tried to verify the smart contract. For example I've used: ct_svN4AGuUh2EJK4WfFQvY39Vpzd7awqmEZiFMybNG9t9gaSp98

What was the code of this contract? Is it some sample contract from aestudio?

Liubov-crypto · 2024-08-12T11:04:48Z

https://studio.aepps.com/

yes, from aestudio

janmichek · 2024-08-12T12:17:02Z

https://studio.aepps.com/

yes, from aestudio

None of the contracts from aestudio cannot be verified or just some of them?

Liubov-crypto · 2024-08-12T12:29:07Z

https://studio.aepps.com/

yes, from aestudio

None of the contracts from aestudio cannot be verified or just some of them?

I tried a couple but was not working for me

janmichek · 2024-08-12T13:32:41Z

Here I deployed some contracts:
I deployed the contracts on behalf of your account. (That's why I needed the seed phrase.)
That makes you deployer and owner of those contracts.
And that enables you to do write actions.

hamster
ct_v5cSYQvkaq5oSKK4BTNBMgptRJSUC57DYwSjgEdGP5oi6Y7ia
ct_JHVDvxUwSNiZDiMEqpjSF15gwPVvqRz2xXqf2vqw8aD76noSf

AeForUsers
ct_22MwK52FbUYi82fQoCBP5ZVU2H8fsY5Ujg8YU356o7BuwLTbY
ct_vtmQYHDzdxGigZD6VeXSgu2Df1XviBSVDRVssZz9bBYVKkXbf

AeUnlockOnTime
ct_p8pcM6H8rdMnHUesw9fskRCFSCs428jthdkwjYyf8sPwr8oxp
ct_vwDoPiv8nohvvW6gER1VrEUqaw21U9Mw4xJ2dmXYxQDAvnAcw

scenario:
Only test testnet of this feature.

Switch the wallet for the account to which you send me the seed

Verify contract (ae studio examples + contract ids above)

goto verified contract detail

go to Write tab

connect wallet, follow instructions

execute write actions

Another testing scenario is that if you want to access Write actions with connected wallet of the user who is NOT deployer of the contracts, then the Write actions should not be accessible (UI is grayed out) @Liubov-crypto

Liubov-crypto · 2024-08-12T15:18:09Z

Got issue with verification again:

2024-08-12.5.59.29.mov

Liubov-crypto · 2024-08-13T15:16:53Z

Finally I've managed to verify at least one contract from the list above: ct_JHVDvxUwSNiZDiMEqpjSF15gwPVvqRz2xXqf2vqw8aD76noSf

but when I followed steps attached in video I got an issue: the page became grey and some issues in console, @janmichek could you check it please:

2024-08-13.6.11.12.mov

janmichek · 2024-08-14T13:07:05Z

Finally I've managed to verify at least one contract from the list above: ct_JHVDvxUwSNiZDiMEqpjSF15gwPVvqRz2xXqf2vqw8aD76noSf

but when I followed steps attached in video I got an issue: the page became grey and some issues in console, @janmichek could you check it please:
2024-08-13.6.11.12.mov

@Liubov-crypto please retry now

Liubov-crypto · 2024-08-15T13:19:08Z

@janmichek There are some issues again: UnsupportedVersionError: Unsupported node version 7.1.0. Supported: >= 6.2.0 < 7.0.0, please check it

2024-08-15.4.12.18.mov

janmichek · 2024-08-20T09:38:43Z

@janmichek There are some issues again: UnsupportedVersionError: Unsupported node version 7.1.0. Supported: >= 6.2.0 < 7.0.0, please check it
2024-08-15.4.12.18.mov

Fixed. You can go ahead and continue with review. The test is not passing but i will solve it in parallel. @Liubov-crypto

davidyuk · 2024-08-28T03:04:35Z

src/components/ContractWritePanel.vue

+  const connectedAddress = walletSdk ? Object.keys(walletSdk._accounts.current)[0] : null
+  return !walletSdk || contractDetails.value.createdBy !== connectedAddress


Suggested change

const connectedAddress = walletSdk ? Object.keys(walletSdk._accounts.current)[0] : null

return !walletSdk || contractDetails.value.createdBy !== connectedAddress

return !walletSdk

This is not an obvious restriction, contract should manage permissions by itself

right, fixed

davidyuk · 2024-08-28T03:07:22Z

For some reason I can't call init function of ct_HzBhnwxXg2zsPAmpX6ppoJNA5q1oojn8ZL2AsWozRxuBFERWD on testnet

davidyuk · 2024-08-28T03:11:32Z

Does it make sense to accept arguments as JSON? I have a contract ct_24UQuk4JbCY2QhxnWvG257CBpirCvoCudXgLFj1MUaedKovUuX on testnet and I can't call its function currently

Consider to combine "read contract" and "write contract" tabs.

janmichek · 2024-08-28T09:48:03Z

ct_HzBhnwxXg2zsPAmpX6ppoJNA5q1oojn8ZL2AsWozRxuBFERWD

Intereseting, I didn't find such a contract on testnet or mainnet. Could you send me the source code, please? I will verify it

janmichek · 2024-08-28T12:50:31Z

For some reason I can't call init function of ct_HzBhnwxXg2zsPAmpX6ppoJNA5q1oojn8ZL2AsWozRxuBFERWD on testnet

Yeah, I think that the init function should not be on the list at all. I filtered it out

Liubov-crypto · 2024-08-30T15:36:23Z

I've verified ct_JHVDvxUwSNiZDiMEqpjSF15gwPVvqRz2xXqf2vqw8aD76noSf and I've putted 11 and 22 into add_test_value
and 2 and 3 into statefully_add_two.

when I rechecked it on Read contract I got in read_test_value 5 as sum 2 and 3, and 33 in locally_add_two. are these numbers correct for the following fields? for me it looks like they switched.

2024-08-30.6.12.22.mov

also I've verified https://pr-872-aescan-testnet.stg.service.aepps.com/contracts/ct_p8pcM6H8rdMnHUesw9fskRCFSCs428jthdkwjYyf8sPwr8oxp?type=contract-write but can't see read contract fields, also new fields on write contract. is it correct?

2024-08-30.6.27.25.mov

when I switched between contract tabs wallet got disconnected.

janmichek · 2024-09-02T09:32:04Z

ct I got in read_test_value 5 as sum 2 and 3, and 33 in locally_add_two. are these numbers correct for the following fields? for me it looks like they switched.

Thanks for the review

It's correct like that. It depends on the order of the actions you run.
also correct, this contract has only writeable entrypoints
interesting. I cannot replicate the issue. Can you send a video to me, please? @Liubov-crypto

Liubov-crypto

I was not able to reproduce ad 3 today.

The rest is LGTM

janmichek requested a review from Liubov-crypto July 31, 2024 14:05

janmichek added 15 commits August 21, 2024 16:08

add mocked UI

6e4cd06

replace code editor supporting contract highlighting

fc61f6e

add verified icon to condensed table

d66e368

add verified icon to condensed table

7854d95

Componentize verified icon

b2923e2

wire verifiaction details to backend

a622b9c

print and format contract code

11b0a1f

remove sample content

40f14eb

fix imports

d02ac7a

fix imports

ad33f82

rename store file

3616aee

display ACI and more information

6806cfb

add badge to contracts in list

ab24fa9

fix is verified condition

902268c

fix is verified condition to contract detail

d904775

janmichek added 11 commits August 21, 2024 16:09

fixes after rebase

eb5df02

remove unused code

1bd4fec

remove unused code

88fd195

fix code style

d3d0328

downgrade sdk version

9044f25

improve write UX

7975feb

remove console logging

127cc3e

downgrade sdk version

235f1a3

regenerate yarn.lock

8700917

upgrade SDK version

8ede3e4

downgrade SDK version

f4e7add

janmichek force-pushed the contract-read branch from 276da42 to f4e7add Compare August 21, 2024 14:09

use corresponding network name

d5b1b3b

davidyuk reviewed Aug 28, 2024

View reviewed changes

janmichek mentioned this pull request Aug 28, 2024

Improve ACI formatting/rendering #899

Closed

remove init endpoint

5b03622

janmichek added 2 commits August 29, 2024 13:11

fix connection condition

5afe4c5

upgrade sdk version

dbbcc51

Liubov-crypto approved these changes Sep 2, 2024

View reviewed changes

janmichek merged commit f5a0f80 into develop Sep 2, 2024
4 checks passed

janmichek deleted the contract-read branch September 2, 2024 16:37

This was referenced Sep 9, 2024

chore(release/0.15.0): release 0.15.0 #918

Merged

chore(release/0.15.1): release 0.15.1 #926

Merged

chore(release/0.15.0): release 0.15.0 #928

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Contract read & write #872

feat: Contract read & write #872

janmichek commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

janmichek commented Jul 31, 2024

janmichek commented Jul 31, 2024

Liubov-crypto commented Aug 8, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

Liubov-crypto commented Aug 13, 2024

janmichek commented Aug 14, 2024

Liubov-crypto commented Aug 15, 2024

janmichek commented Aug 20, 2024 •

edited

Loading

davidyuk Aug 28, 2024

janmichek Aug 28, 2024

davidyuk commented Aug 28, 2024

davidyuk commented Aug 28, 2024

janmichek commented Aug 28, 2024

janmichek commented Aug 28, 2024

Liubov-crypto commented Aug 30, 2024

janmichek commented Sep 2, 2024 •

edited

Loading

Liubov-crypto left a comment

		const connectedAddress = walletSdk ? Object.keys(walletSdk._accounts.current)[0] : null
		return !walletSdk \|\| contractDetails.value.createdBy !== connectedAddress

	const connectedAddress = walletSdk ? Object.keys(walletSdk._accounts.current)[0] : null
	return !walletSdk \|\| contractDetails.value.createdBy !== connectedAddress
	return !walletSdk

feat: Contract read & write #872

feat: Contract read & write #872

Conversation

janmichek commented Jul 31, 2024 • edited Loading

Description

Demo

Checklist:

github-actions bot commented Jul 31, 2024

janmichek commented Jul 31, 2024

janmichek commented Jul 31, 2024

Liubov-crypto commented Aug 8, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

janmichek commented Aug 12, 2024

Liubov-crypto commented Aug 12, 2024

Liubov-crypto commented Aug 13, 2024

janmichek commented Aug 14, 2024

Liubov-crypto commented Aug 15, 2024

janmichek commented Aug 20, 2024 • edited Loading

davidyuk Aug 28, 2024

Choose a reason for hiding this comment

janmichek Aug 28, 2024

Choose a reason for hiding this comment

davidyuk commented Aug 28, 2024

davidyuk commented Aug 28, 2024

janmichek commented Aug 28, 2024

janmichek commented Aug 28, 2024

Liubov-crypto commented Aug 30, 2024

janmichek commented Sep 2, 2024 • edited Loading

Liubov-crypto left a comment

Choose a reason for hiding this comment

janmichek commented Jul 31, 2024 •

edited

Loading

janmichek commented Aug 20, 2024 •

edited

Loading

janmichek commented Sep 2, 2024 •

edited

Loading