feat: Ae coin details #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liubov-crypto
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
I think it's worth to check if text is placed in green filed when copy it:
https://github.com/aeternity/aescan/assets/69896204/9f2a4278-1c3c-4adc-b270-097bed6d0ca1
Also for short names of tokens (the same on prod) and aligning is different from prod:
https://github.com/aeternity/aescan/assets/69896204/92198165-f7fe-4bc5-9246-7725fa223800
Fixed
The layout is good. That's the thing we changed lately |
michele-franchi
requested changes
Jun 5, 2024
src/components/AeCoinPanel.vue
Outdated
| fetchMarketStats(), | ||
| ])) | ||
|
|
||
| const priceChangeSign = computed(() => priceChange.value > 0 ? '+' : '') |
There was a problem hiding this comment.
Suggested change
| const priceChangeSign = computed(() => priceChange.value > 0 ? '+' : '') | |
| const priceChangeSign = computed(() => priceChange.value > 0 ? '+' : '') |
Shouldn't it be:
> 0: '+'
=0: ''
<0: '-'
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #749
Demo
firefox_5N0gx7UBRu.mp4
Checklist: