fix: replace hc check to use the node functions #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would that still crash the mdw if the parent ode is temporarily unavailable? |
It will retry until it's available |
sborrazas
reviewed
Feb 4, 2025
mix.exs
Outdated
| @@ -106,7 +106,8 @@ defmodule AeMdw.MixProject do | |||
| :sext, | |||
| :rocksdb, | |||
| :telemetry, | |||
| :aeapi | |||
| :aeapi, | |||
| :aec_parent_connector | |||
There was a problem hiding this comment.
Can we keep this sorted alphabetically?
sborrazas
approved these changes
Feb 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the mdw checks for a connection to the parent chain in a way that delegates the error handling to the node. The biggest difference is that now the node process responsible for the connection controlls when the code errors out. Now if the parent is reachable it checks periodically to see if the start_height is reached. Otherwise if it is unreachable the node gives a warning and checks again after a short interval.