feat: add endpoint to get the total count of transactions for a given period #2074
Conversation
lib/ae_mdw/stats.ex
Outdated
|
|
||
| :backward | ||
| |> streamer.() | ||
| |> Enum.reduce(0, fn index, acc -> |
There was a problem hiding this comment.
Like we've been over before. We should never go through an unlimited list of things, this sooner or later is going to impact performance and is going to cause server downtime. We need to index everything that we query for in the database
There was a problem hiding this comment.
I don't think it's a problem here since we have ~3k records and we can also limit the request to be able to scope up to some time
There was a problem hiding this comment.
This would be the first request that depends on the amount of records stored in the database in order to work properly. I would rather avoid going down that rabbit hole, results should be always immediate, regardless of the amount of records
| @@ -622,6 +622,47 @@ paths: | |||
| application/json: | |||
| schema: | |||
| $ref: '#/components/schemas/ErrorResponse' | |||
| /stats/transactions/total: | |||
There was a problem hiding this comment.
I would use the existing route we have for counting transactions /transactions/count with a scope param where you scope by generation or time and the existing tx_type filter
There was a problem hiding this comment.
That route doesn't allow using scope and tx_type at the same time
There was a problem hiding this comment.
Maybe we can allow that since it would be the same as what this new route does already
resolves: #2054