Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround to not require hnsw batch params when updating an index #7

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jdogmcsteezy
Copy link
Member

There is still a limitation: If you provide one of the batch indexes, you must provide both.

Also, I remove the update prompt per Adam's request

…ex. Also remove prompt

There is still a limitation where if any batch param is provided all others must also be provided
Copy link

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy changed the title fix: fix: Workaround to not require hnsw batch params when updating an index fix: Workaround to not require hnsw batch params when updating an index Jul 19, 2024
@jdogmcsteezy jdogmcsteezy merged commit ff48bea into main Jul 19, 2024
5 checks passed
@jdogmcsteezy jdogmcsteezy deleted the fix-update-batch-required branch July 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants