Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vec 210 acl #3

Merged
merged 26 commits into from
Jul 3, 2024
Merged

Vec 210 acl #3

merged 26 commits into from
Jul 3, 2024

Conversation

jdogmcsteezy
Copy link
Member

Includes:

  • Changing command syntax to index create vs create index
  • user create
  • user ls
  • user drop
  • user grant
  • user revoke
  • user new-password
  • role ls

Copy link

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some help text changes and nitpicks and suggestions

Makefile Outdated Show resolved Hide resolved
cmd/role.go Show resolved Hide resolved
cmd/rolesList.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
cmd/userCreate.go Outdated Show resolved Hide resolved
cmd/userList.go Outdated Show resolved Hide resolved
cmd/userNewPassword.go Show resolved Hide resolved
cmd/userNewPassword.go Outdated Show resolved Hide resolved
func newUserRevokeFlagSet() *pflag.FlagSet {
flagSet := &pflag.FlagSet{}
flagSet.AddFlagSet(userRevokeFlags.clientFlags.NewClientFlagSet())
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to grant new roles.")) //nolint:lll // For readability

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to grant new roles.")) //nolint:lll // For readability
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to revoke roles from.")) //nolint:lll // For readability

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 86.25850% with 101 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5700529). Learn more about missing BASE report.

Files Patch % Lines
cmd/userNewPassword.go 74.32% 15 Missing and 4 partials ⚠️
cmd/utils.go 32.00% 17 Missing ⚠️
cmd/rolesList.go 80.00% 8 Missing and 3 partials ⚠️
cmd/userCreate.go 85.13% 8 Missing and 3 partials ⚠️
cmd/userList.go 80.00% 8 Missing and 3 partials ⚠️
cmd/userDrop.go 85.24% 6 Missing and 3 partials ⚠️
cmd/indexDrop.go 88.40% 5 Missing and 3 partials ⚠️
cmd/userGrant.go 93.15% 3 Missing and 2 partials ⚠️
cmd/userRevoke.go 93.15% 3 Missing and 2 partials ⚠️
cmd/root.go 40.00% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   84.70%           
=======================================
  Files           ?       28           
  Lines           ?     1308           
  Branches        ?        0           
=======================================
  Hits            ?     1108           
  Misses          ?      153           
  Partials        ?       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdogmcsteezy jdogmcsteezy merged commit 7a3906b into main Jul 3, 2024
4 checks passed
@dwelch-spike
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants