Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install fails on Windows if user dir has spaces in it #441

Closed
jhecking opened this issue Dec 14, 2021 · 3 comments
Closed

npm install fails on Windows if user dir has spaces in it #441

jhecking opened this issue Dec 14, 2021 · 3 comments

Comments

@jhecking
Copy link
Contributor

One other thing I forgot to mention: If your windows user folder ("c:\Users\Your Name") has spaces on it, the process also fails. It seems that spaces are not properly escaped inside one of the scripts, so you need to run this from an account that has no spaces on its home path -OR- change your current account home path, which might be a little bit nerve wracking.

Originally posted by @raphaabreu in #439 (comment)

@jhecking
Copy link
Contributor Author

I wish I had saved the logs when I was having the issues with spaces in the windows user home path, but since that was a huge pain with other apps as well, I decided to do a fresh install and to make sure that I had no spaces in my home folder.

As to where the issue manifested, it surfaced on this line:

$process = Invoke-MsBuild -PassThru -Path $projectfile -Params $params -BuildLogDirectory $logdir -ShowBuildOutputInCurrentWindow:$verbose

It seemed to me whatever was calling the 'build-c-client.ps1' was not scaping or using " " to pass arguments, because the arguments seemed to be out of order when the msbuild was being invoked. Moving the project to a folder outside of my home did not help either because one of the paths was pointing to my npm folder insite my user/appdata.

Originally posted by @raphaabreu in #439 (comment)

@DomPeliniAerospike
Copy link
Collaborator

Not planning to fix this, just don't put spaces in the folder name.

@DomPeliniAerospike DomPeliniAerospike closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@raphaabreu
Copy link

I understand that this is a minor issue and that there are workarounds, but this sort of answer does say a lot about how a company cares about their developer experience. I have to tell each dev that joins my team that they MUST use a specific folder structure if they are going to touch any repositories that are using Aerospike. Show me one successful technology vendor that does this kind of stuff.

There should be at least a warning so that if someone tries to install in a path that has spaces on it, that they should try installing on C:\whatever instead. I did take the time to go deep into these install instructions to understand what was going on. It is not feasible to have each dev go through this on their own.

Aerospike is an awesome tool, but I make a conscious effort to use it as little as I possibly can because of the developer experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants