Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __main__.py #63

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Update __main__.py #63

merged 1 commit into from
Aug 7, 2019

Conversation

algchyhao
Copy link
Contributor

@algchyhao algchyhao commented Aug 7, 2019

delete "." in line 3
from .swmmio import Model -> from swmmio import Model
resolve the error: "from swmmio.swmmio import Model, no module named swmmio" balabala......

Closes #61

delete "." in line 3
from .swmmio import Model -> from swmmio import Model
resolve the error: "from swmmio.swmmio import Model, no module named swmmio" balabala......
@aerispaha
Copy link
Member

@algchyhao thanks for this fix!

Note that I've also updated the dependecies in requirements.txt and setup.py to explicitly set the version number for each dependency of swmmio. Because these weren't previously set explicitly, we were running into compatibility issues with the Windows Python 2.7 builds (which is why some of tests on this PR failed at first).

All of this will be included in the next swmmio release. For now, I recommend pulling down these updates in from the master branch v0.3.6.dev0

@aerispaha aerispaha self-requested a review August 7, 2019 14:56
Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aerispaha aerispaha added this to the v0.4.0 milestone Aug 7, 2019
@aerispaha aerispaha added the bug label Aug 7, 2019
@aerispaha aerispaha merged commit 237c954 into pyswmm:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error "no module named swmmio"
2 participants