Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataframe_from_rpt fails if more than one element is provided in the section #93

Closed
kristianfoerster opened this issue May 12, 2020 · 1 comment · Fixed by #95
Closed

Comments

@kristianfoerster
Copy link

Starting with version 0.4.0 dataframe_from_rpt only works properly if only one element exists in the corresponding section. If there are more than one element (e.g., subcatchments), the returned pd.DataFrame object is invalid, since it includes the results of all elements as well as the string comments between the time series. I was wondering if it's worth to add the element_id argument to the function call (as it was available in swmmio-0.3.x. Thank you!

@aerispaha
Copy link
Member

Thanks for catching this @kristianfoerster! I think I have a fix to restore this feature in the dev branch here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants