Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version_control module fails in directories with spaces in the path #8

Closed
aerispaha opened this issue Dec 12, 2016 · 1 comment · Fixed by #56
Closed

version_control module fails in directories with spaces in the path #8

aerispaha opened this issue Dec 12, 2016 · 1 comment · Fixed by #56

Comments

@aerispaha
Copy link
Member

Root cause seems to be the swmmio.dataframes,create_dataframeBI() function having trouble parsing the "Origin" column where file paths of parent INPs are written.

This process should probably reference a relative folder structure.

@aerispaha aerispaha added the bug label Aug 4, 2018
@aerispaha aerispaha added this to the v0.3.0 milestone Oct 11, 2018
@aerispaha aerispaha modified the milestones: v0.3.1, v0.3.2 Nov 20, 2018
@aerispaha
Copy link
Member Author

This occurs because the parser fails to deal with a columns that aren't strictly space delimited. This is how the test is currently being parsed:

              Name  InvertElev  MaxDepth  InitDepth  SurchargeDepth PondedArea        ;                                       Comment Origin
dummy_node1 -15.00        30.0         0          0               0          ;  Altered  C:\PROJECTCODE\swmmio\swmmio\tests\data\root    ...
dummy_node5  -6.96        15.0         0          0           73511          ;  Altered  C:\PROJECTCODE\swmmio\swmmio\tests\data\root    ...

Because the Origin has spaces, the columns become unaligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant