Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Wrong FCN paper reference #2439

Closed
adilsonmedronha opened this issue Dec 11, 2024 · 3 comments
Closed

[DOC] Wrong FCN paper reference #2439

adilsonmedronha opened this issue Dec 11, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@adilsonmedronha
Copy link
Contributor

adilsonmedronha commented Dec 11, 2024

Describe the issue linked to the documentation

The reference for the FCNClassifier implementation is stated to have been adapted from:

  • [1] Zhao et al., Convolutional Neural Networks for Time Series Classification, Journal of Systems Engineering and Electronics, 28(1):2017.

However, the reference should point to the paper that originally proposed the FCN:

  • [1] Z. Wang, W. Yan and T. Oates, "Time series classification from scratch with deep neural networks: A strong baseline," 2017 International Joint Conference on Neural Networks (IJCNN), Anchorage, AK, USA, 2017, pp. 1578-1585.

Suggest a potential alternative/fix

Let "Notes" to be the observation that this FCN implementation was adapted from Fawaz et. al, but mention the orignal paper in the "References".

Notes
-----
Adapted from the implementation from Fawaz et. al
https://github.com/hfawaz/dl-4-tsc/blob/master/classifiers/fcn.py

References
----------
.. [1] Z. Wang, W. Yan and T. Oates, "Time series classification from scratch with deep neural networks: A strong baseline," 2017 International Joint Conference on Neural Networks (IJCNN), Anchorage, AK, USA, 2017, pp. 1578-1585.
@adilsonmedronha adilsonmedronha added the documentation Improvements or additions to documentation label Dec 11, 2024
@adilsonmedronha
Copy link
Contributor Author

@aeon-actions-bot assign @adilsonmedronha

@MatthewMiddlehurst
Copy link
Member

Please use the PR template and link issues in the future so these are closed when the PR is merged.

@MatthewMiddlehurst
Copy link
Member

#2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants