Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when Library directory doesn't exists #38

Closed
jdvr opened this issue Sep 11, 2022 · 4 comments
Closed

Fail when Library directory doesn't exists #38

jdvr opened this issue Sep 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@jdvr
Copy link
Contributor

jdvr commented Sep 11, 2022

Describe the bug

On Linux OS the Library subdirectory doesn't exists by default.

To Reproduce
Steps to reproduce the behavior:

❯ ghpew
github-pewpew v1.2.2
Clean up and remove those unnecessary GitHub repositories. Pew pew!

Sign in to GitHub:
Open: https://github.com/login/device
Code: XXXX-XXXX Copied to clipboard!

< --- Follow process on web browser --- >

Error: ENOENT: no such file or directory, mkdir '/home/jdvr/Library/com.adrianmg.github-pewpew'

Expected behavior
it works

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information:**

  • OS: KDE Neon (Ubuntu 20.04)
  • Terminal zsh
  • Version 1.2.2

Additional context
Add any other context about the problem here.

@davidsneighbour
Copy link

In connection with this, it seems that Library is a quite Mac-centric directory. I don't want a Library folder in my home directory on a linux system. Using a system path (like .config on Ubuntu or even within the npm installation directory) might be a better solution.

@jdvr
Copy link
Contributor Author

jdvr commented Sep 26, 2022

In connection with this, it seems that Library is a quite Mac-centric directory. I don't want a Library folder in my home directory on a linux system. Using a system path (like .config on Ubuntu or even within the npm installation directory) might be a better solution.

Not a bad idea, I think we could set ~/.config/pewpew as config directory for Linux

@adrianmg
Copy link
Owner

Thanks for reaching out @davidsneighbour! This makes total sense. Do you care to contribute to the open PR?

@adrianmg
Copy link
Owner

adrianmg commented Oct 2, 2022

Fixed in #37

@adrianmg adrianmg closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants