Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set referrer policy for external link #823

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Set referrer policy for external link #823

merged 3 commits into from
Jul 9, 2020

Conversation

pmboothby
Copy link
Contributor

As per suggestions and comments by @adriankumpf and @baylanger I've added noreferrer to the external link.

Teslascope copy Tesla's release notes to their website using a URL with the version number in it, so very easy to link to.
As per suggestions/comments from previous change,  added *rel="noreferrer"* to links to Tesla software update details on teslascope.com.
Copy link
Contributor

@baylanger baylanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noreferrer 👍

@adriankumpf
Copy link
Collaborator

Hey @pmboothby, thanks for the PR. I tried it and it worked great. Unfortunately, this branch cannot be merged yet due to conflicts. Could you resolve those?

@pmboothby
Copy link
Contributor Author

Ooops. Missed that conflict. Fixed now.

Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriankumpf adriankumpf merged commit 69e49be into teslamate-org:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants