-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Consumption Unit to Watt-hour to Match In-Car Unit #717
Conversation
Modify Consumption column to Watt-hour (Wh) unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
Modify Consumption (net) / (gross) Singlestat values and Consumption/100mi table column to Watt-hour (Wh) unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Using Wh/km everywhere definitely makes sense. Only a few minor changes need to be made before this can be merged :)
Remerge master drives.json to include lastest commits
Include length unit in consumption value. Wh/km or Wh/mi
Include length unit in consumption value. Wh/km or Wh/mi
Modify Consumption column to Watt-hour per length unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
Modified it a bit more to include the length unit. |
Fix Consumption panel postfix value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thanks!
"mappingType": 1, | ||
"pattern": "consumption_km", | ||
"thresholds": [], | ||
"type": "number", | ||
"unit": "kwatth" | ||
"unit": "Wh/km" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Updated Consumption unit in Drives and Efficiency dashboards to Watt-hour (Wh) per #675