Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese (Traditional) translation #633

Merged
merged 7 commits into from
Apr 23, 2020
Merged

Add Chinese (Traditional) translation #633

merged 7 commits into from
Apr 23, 2020

Conversation

occultsound
Copy link
Contributor

Add Traditional Chinese (taiwan) translation

Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you, @occultsound.

# # to merge POT files into PO files.
msgid ""
msgstr ""
"Language: zh_Hant\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, an An IETF BCP 47 language tag is required, which is why I had to replace it with a tag from the IANA Language Subtag Registry. The CLDR library we use only supports a subset: https://github.com/elixir-cldr/cldr/tree/master/priv/cldr/locales Hence "zh_Hant". Hope that's okay :) The same applies to the folder name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@adriankumpf adriankumpf merged commit 0f22867 into teslamate-org:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants