Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Apple mobile web app capable meta tag #2128

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Added Apple mobile web app capable meta tag #2128

merged 1 commit into from
Nov 5, 2021

Conversation

herbit
Copy link
Contributor

@herbit herbit commented Nov 3, 2021

Enable to run the website in full screen mode on iPhones. This is useful in combination when starting TeslaMate with an app icon from the home screen.

Enable to run the website in full screen mode on iPhones. This is useful in combination when starting TeslaMate with an app icon from the home screen.
@adriankumpf
Copy link
Collaborator

I cannot see any difference with this meta tag enabled. A quick Google search only brought up this archive link on Apple's Developer Docs and a few references to it being deprected.

@herbit
Copy link
Contributor Author

herbit commented Nov 5, 2021

I guess apples documentation is really bad. It is recommended by google for full screen apps, though: https://developers.google.com/web/fundamentals/native-hardware/fullscreen/
Grafana also uses it and the TeslaMate Grafana page opens full screen on my iPhone when launched from an home screen icon. The TeslaMate main page opens in Safari when launched from an home screen icon.

@adriankumpf
Copy link
Collaborator

I guess apples documentation is really bad. It is recommended by google for full screen apps, though: https://developers.google.com/web/fundamentals/native-hardware/fullscreen/ Grafana also uses it and the TeslaMate Grafana page opens full screen on my iPhone when launched from an home screen icon. The TeslaMate main page opens in Safari when launched from an home screen icon.

I launch TeslaMate via a home screen icon since ages and it opens in full screen mode just fine 🤔 Did you test if these changes make a difference for you?

@herbit
Copy link
Contributor Author

herbit commented Nov 5, 2021

I don't have the toolchain installed. What I did for a quick PoC:

  1. copy the html source of my running TeslaMate page and saving it as static .html file
  2. make it available on a local web server
  3. Accessing the URL with Mobile Safari on my iPhone and add it the home screen
  4. Starting via the home screen icon
  5. Outcome: opens in Safari

Now I've added "apple-mobile-web-app-capable" meta tag to the static html and repeated the steps 2-4. It now opens full screen.

Edit: Device is an iPhone 11 with iOS 15.1

@adriankumpf
Copy link
Collaborator

All right, thanks for testing. If it solves the problem, let's merge it.

@adriankumpf adriankumpf merged commit b1b5365 into teslamate-org:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants