Change some dashboards to browser local time #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I wrong or didn't grafana already convert epoch time to local browser time /w $__time(column)? I'm not questioning your approach, I am genuinely curious :) |
Yes it did, however Grafana was inconsistent and didn't use this approach across all its plugins. If you look at my previous fix for this I was restricted to Date|Time_US & DateTime ISO. Luckily this approach is no longer needed with the move to the latest version of Grafana. |
Ed-M72
changed the title
Ed-M72
changed the title
adriankumpf
approved these changes
Jun 18, 2021
adriankumpf
pushed a commit
that referenced
this pull request
Jun 18, 2021
Co-authored-by: emellodew <64371467+emellodew@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration to Grafana 7.4 we now have the option of using the browser locale, and therefore catering for peoples local date/time format, aka they should now support the UK date format. #1692
The following dashboards have been updated to reflect this:
Updates,
States
Stastistics.
There are three further dashboards which require updating, they are:
Charges
Drives
Vampire Drain,
However these are more complicated and require the panels to be upgraded to a newer version, so will be dealt with soon.