Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeline dashboard #1621

Merged
merged 11 commits into from
Jun 1, 2021
Merged

Add Timeline dashboard #1621

merged 11 commits into from
Jun 1, 2021

Conversation

DrMichael
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dashboard turned out real nice! 👏 Hopefully the longstanding Grafana issue gets included in v8.0.0-beta2 so we can finally hide those utility columns.

grafana/dashboards/timeline.json Outdated Show resolved Hide resolved
grafana/dashboards/timeline.json Show resolved Hide resolved
grafana/dashboards/timeline.json Show resolved Hide resolved
@adriankumpf
Copy link
Collaborator

I noticed two more things:

  • Joining the next drives by adding + 1 to the drive id cannot be relied on. Drives will be deleted if the distance driven is 0, for instance, or if deleted manually.
  • The query should not assume that the ideal range is the default. Better: use [[preferred_range]]_battery_range_km to take the configured preferred range into account.

I'll try to fix it when I have time.

@DrMichael
Copy link
Collaborator Author

DrMichael commented May 21, 2021

  • Joining the next drives by adding + 1 to the drive id cannot be relied on. Drives will be deleted if the distance driven is 0, for instance, or if deleted manually.

That is a pity. I found "missing" the most interesting part. Maybe it would work with lag(id) OVER (ORDER BY id)? Or similar? PSQL wizard needed!!! :-)

@adriankumpf adriankumpf merged commit 305e0a9 into teslamate-org:master Jun 1, 2021
TsuyoshiUshi added a commit to TsuyoshiUshi/teslamate that referenced this pull request Jul 15, 2022
* Add Timeline dashboard

* Changes according to teslamate-org/teslamate#1621

Except the filter.

* Add dashboard links, fix action filter

* Fix subquery to get parking sessions

* Use preferred range to fix consumption calculation

* Remove "Missing" category

* Cast range values to numeric

* Convert temperatures

* Make Cost car specific. (Fixes #1641 )

Co-authored-by: Adrian Kumpf <8999358+adriankumpf@users.noreply.github.com>
flooppmtn added a commit to flooppmtn/teslamate that referenced this pull request Aug 24, 2022
* Add Timeline dashboard

* Changes according to teslamate-org/teslamate#1621

Except the filter.

* Add dashboard links, fix action filter

* Fix subquery to get parking sessions

* Use preferred range to fix consumption calculation

* Remove "Missing" category

* Cast range values to numeric

* Convert temperatures

* Make Cost car specific. (Fixes #1641 )

Co-authored-by: Adrian Kumpf <8999358+adriankumpf@users.noreply.github.com>
ClarkWalker pushed a commit to ClarkWalker/wall that referenced this pull request Nov 12, 2022
* Add Timeline dashboard

* Changes according to teslamate-org/teslamate#1621

Except the filter.

* Add dashboard links, fix action filter

* Fix subquery to get parking sessions

* Use preferred range to fix consumption calculation

* Remove "Missing" category

* Cast range values to numeric

* Convert temperatures

* Make Cost car specific. (Fixes #1641 )

Co-authored-by: Adrian Kumpf <8999358+adriankumpf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants