Fix eventmappings when value is empty or 0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For streamRevision, for example, because 1st revision value is 0, streamRevision is not copied in the payload
|
can you refactor the isNullOrUndefined function to work with node 0.10 too? |
|
Is that a "no-luck" CI failure ? |
adrai
added a commit
that referenced
this pull request
Feb 29, 2016
Fix eventmappings when value is empty or 0
|
v1.7.1 |
|
Thanks for the merge and the publishing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For streamRevision, for example, because 1st revision value is 0, streamRevision is not copied in the payload : the value is bypassed because of the test in the
ifstatement