Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDestroying is false when x-option (& x-select) are being destroyed (Ember 2.8 beta) #138

Closed
Robdel12 opened this issue Aug 30, 2016 · 1 comment
Labels
Milestone

Comments

@Robdel12
Copy link
Collaborator

When you navigate to the dummy apps /ember-data route and then try to navigate away look in the console for an error. Should be:

Uncaught Error: Attempted to handle event `didSetProperty` on <dummy@model:person::ember555:null> while in state root.deleted.saved. Called with {name: name, oldValue: undefined, originalValue: undefined, value: null}.

This is because we're trying to set the value on a deleted ember data object. What's happening is here this.get('isDestroying') is false which means we're going to call _updateValue() and go 💥 .

Possibly related to:
emberjs/ember.js#13775
emberjs/ember.js#14110
emberjs/ember.js#14159

Version of x-select:

v2.2.1

Ember Version / Ember CLI Version:

Ember Version: Ember beta
Ember CLI Version: 2.7

Expected Behavior

Navigate to the /ember-data route in the dummy app and then navigate away. There should be no console errors.

Actual Behavior

When you navigate away from the /ember-data route it goes 💥

Steps To Reproduce:

  1. Install ember 2.8 beta.
  2. Navigate to /ember-data
  3. Navigate away from that route.
  4. Look at the console
@Robdel12 Robdel12 added this to the v2.2.2 milestone Aug 30, 2016
@Robdel12 Robdel12 added the Bug label Aug 30, 2016
@Robdel12
Copy link
Collaborator Author

Robdel12 commented Sep 4, 2016

Closed with #142

@Robdel12 Robdel12 closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant