Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update store:main references to use store:application as store:main is now deprecated #90

Merged
merged 1 commit into from
Jun 11, 2015

Conversation

jcope2013
Copy link
Contributor

fixs

DEPRECATION: You tried to look up 'store:main', but this has been deprecated in favor of 'store:application'.
        at ember$data$lib$system$container$proxy$$ContainerProxy.registerDeprecation.preLookupCallback (http://localhost:4200/provider/assets/vendor.js:125945:15)
        at Object.ember$data$lib$system$container$proxy$$ContainerProxy.aliasedFactory.create (http://localhost:4200/provider/assets/vendor.js:125929:13)
        at instantiate (http://localhost:4200/provider/assets/vendor.js:17010:26)
        at lookup (http://localhost:4200/provider/assets/vendor.js:16849:19)
        at Object.Container.lookup (http://localhost:4200/provider/assets/vendor.js:16494:16)
        at exports.default.initialize (http://localhost:4200/provider/assets/inbox-dashboard.js:7014:48)
        at http://localhost:4200/provider/assets/vendor.js:18175:11
        at visit (http://localhost:4200/provider/assets/vendor.js:17098:7)
        at DAG.topsort (http://localhost:4200/provider/assets/vendor.js:17210:11)

emberjs/data#3136

@danielspaniel
Copy link
Collaborator

This is a great start @jcope2013 , but beta.19 has another few things that kill factory guy .. which is why the tests are still failing. The other big big issue is that you can no longer pass in a record in the relationship when you make a model ( push to the store ) ..
anyway .. if you feel like fixing that too .. then let me know, otherwise, I will merge this before I start working on that change within the next few days.

@jcope2013
Copy link
Contributor Author

@danielspaniel "the other big big issue is that you can no longer pass in a record in the relationship when you make a model ( push to the store )" hmm? an example? not seeing this issue so far in my app but maybe i am not sure what you mean

@danielspaniel
Copy link
Collaborator

I guess that does sound a bit obscure @jcope2013 , but if you run the tests on your branch and you see the failing tests, you will catch my meaning. But not to worry anyway, because I am 90% done with fixing that issue anyway. I pulled your branch and am working on fixing all the tests right now. Will merge it soon, probably tomorrow latest.

@danielspaniel danielspaniel reopened this Jun 11, 2015
@danielspaniel danielspaniel merged commit 06929a2 into adopted-ember-addons:master Jun 11, 2015
@danielspaniel
Copy link
Collaborator

@jcope2013 , new version 1.0.11 is released and ready to go for beta-19

@sirvine
Copy link

sirvine commented Jun 15, 2015

FYI — looks like this change got rolled back: emberjs/data#3316

@danielspaniel
Copy link
Collaborator

Hmm .. interesting .. puzzling .. thanks for the heads up @sirvine

@jcope2013
Copy link
Contributor Author

this is the new recommended path moving forward, its currently on canary but i think the store:application switch above still works even with the rollback of the PR

"Deprecate store:main and store:application and recommend users always use service:storeapp/services/store.js to prevent duplicate stores."

emberjs/data@aaa16d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants