Tests for mockUpdate.match #216 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Went ahead and committed the update via a 'mock-request-match' class that both update and create inherit from. Feel free to use or go with a different approach. |
|
I am thinking that a mixin would be nicer .. they are hard to do with classes .. but I will give it a whirl Wish everything was that simple. |
|
All set .. converted to mixin style. |
|
v2.7.0-beta.10 has this new code .. thanks for the help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some tests for mockUpdate().match().
The tests pass and it works how I need in my own app's tests when I copy the methods match(), extraRequestMatches(), and attributesMatch() from mock-create-request.js to mock-update-request.js.
But you probably want something cleaner than a copy/paste job. Not sure if there would be any variation for update. If not, maybe a 'mock-match-request' class with those methods which both create and update extend.