Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart data updator bug #34

Closed
SamiSammour opened this issue Aug 16, 2015 · 4 comments
Closed

chart data updator bug #34

SamiSammour opened this issue Aug 16, 2015 · 4 comments

Comments

@SamiSammour
Copy link

Hi there,
there is a problem when updating the chart when the new data length is less than the previous one.
for example if you have the dataset.data.length = 10 then the new dataset.data.length = 3 the chart first 3 points is updated but the rest are still drawn.

@sbatson5
Copy link

I experience this issue with line charts as well. For example:

screen shot 2015-09-30 at 1 41 25 pm

Then updating the number of years we chart:

screen shot 2015-09-30 at 1 42 10 pm

So my array of datapoints has changed length and I would want the whole chart to redraw. However, there may be use cases where you want to only update the first few data points. Would it make sense to add a property that forces redraw?

{{ember-chart type="Line" data=chartData options=chartOptions forceRedraw=true width=500 height=300}}

Or something to that effect?

@sbatson5
Copy link

@aomran I wrote another PR which should address this. The issue is that if the number of points for an item changes, the chart won't redraw since we are still charting the same number of datasets. PR with unit test is here:
#37

@aomran
Copy link
Collaborator

aomran commented Mar 12, 2016

pull request #37 was merged -- that might address this

@aomran
Copy link
Collaborator

aomran commented May 8, 2016

Closing this issue since it's been a while and the next major version is being worked on here: #54.

@aomran aomran closed this as completed May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants