Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db:seed and migration:fresh use default connection, and not that supplied by the --connection flag #996

Closed
ghost opened this issue Feb 5, 2024 · 6 comments
Labels
Good First Issue Want to contribute? Just filter by this label

Comments

@ghost
Copy link

ghost commented Feb 5, 2024

Package version

18.4.2

Describe the bug

Running ace db:seed and ace migration:fresh seems to ignore the --connection flag. ace db:wipe and ace migration:run respect the connection flag as expected.

Reproduction repo

No response

@ghost
Copy link
Author

ghost commented Feb 5, 2024

Worked out the issue somewhat - the connection info isn’t being passed to any of the functions in the seeders’ run() methods.

@thetutlage
Copy link
Member

Can you please create a PR for the same. It should be created for the v18 branch. https://github.com/adonisjs/lucid/tree/v18

@RomainLanz RomainLanz added the Good First Issue Want to contribute? Just filter by this label label Feb 15, 2024
@RomainLanz
Copy link
Member

He deleted his account.

I have added the flag Good First Issue if anyone want to make a contribution!

@RomainLanz
Copy link
Member

In fact, I believe this PR may fix the issue: #983

@aarhusgregersen
Copy link

Did it indeed fix the issue? Or is this still something that should be looked at? :-)

@thetutlage
Copy link
Member

Yes, it did. Also, feel free to give it a try and report back if the issue persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Want to contribute? Just filter by this label
Projects
None yet
Development

No branches or pull requests

3 participants