Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snaps are too large for CRAN submission #469

Open
adokter opened this issue Jun 28, 2021 · 5 comments
Open

snaps are too large for CRAN submission #469

adokter opened this issue Jun 28, 2021 · 5 comments
Assignees
Milestone

Comments

@adokter
Copy link
Owner

adokter commented Jun 28, 2021

Hi @CeciliaNilsson709 and @peterdesmet,

I noticed the snaps you have added for plot testing are very large, 85 Mb in total currently. This makes the package size increase from ~ 5Mb previously to almost 10Mb, and this is too large for CRAN (5Mb max).

Is there a way of not including snaps in CRAN submissions?

@adokter adokter added this to the 0.6.0 milestone Jun 28, 2021
@peterdesmet
Copy link
Collaborator

Can we include these in .Rbuildignore or won't we be able to use them for the tests then?

@adokter
Copy link
Owner Author

adokter commented Jun 29, 2021

Added _snaps to .Rbuildignore in commit ee04294a46bc9e88e9cf06fa44d0847f53fcf163. This reduces the package size back to ~5Mb, but unfortunately the tests are now skipped, both on Github and when running local devtools::check(). Hitting the "Run Tests" button in Rstudio for test-plot.vpts.R does still work

@peterdesmet
Copy link
Collaborator

Ok, good to know, ignoring might not be the best option then. It’s mainly the vpts snaps that are huge, could reduce x-axis for those.

We can also have a skip_if function for these visual tests, cf. docker, but that doesn’t solve the size issue.

We also still have the option of moving some files (not the snaps) to zenodo.

@adokter
Copy link
Owner Author

adokter commented Jun 30, 2021

Besides the snaps we still have a package size issue, we are at 5.7 Mb without snaps, with 5.0 Mb being the max. Reopening #376

@CeciliaNilsson709
Copy link
Collaborator

Reducing the x axis on the plots does help a lot, but we are still way too far from being able to include them, especially if we are already over. We could use skip_on_cran() for the visual tests, would that be an option? Not how that would affect code coverage etc..

The example vpts file covers 10 days, we could shorten it? I would think that a shorter time frame would work equally well for most examples?

@adokter adokter modified the milestones: 0.6.0, 0.7.0 Apr 29, 2022
@adokter adokter modified the milestones: 1.0.0, 1.1.0 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants