-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snaps are too large for CRAN submission #469
Comments
Can we include these in |
Added _snaps to |
Ok, good to know, ignoring might not be the best option then. It’s mainly the vpts snaps that are huge, could reduce x-axis for those. We can also have a skip_if function for these visual tests, cf. docker, but that doesn’t solve the size issue. We also still have the option of moving some files (not the snaps) to zenodo. |
Besides the snaps we still have a package size issue, we are at 5.7 Mb without snaps, with 5.0 Mb being the max. Reopening #376 |
Reducing the x axis on the plots does help a lot, but we are still way too far from being able to include them, especially if we are already over. We could use The example vpts file covers 10 days, we could shorten it? I would think that a shorter time frame would work equally well for most examples? |
Hi @CeciliaNilsson709 and @peterdesmet,
I noticed the snaps you have added for plot testing are very large, 85 Mb in total currently. This makes the package size increase from ~ 5Mb previously to almost 10Mb, and this is too large for CRAN (5Mb max).
Is there a way of not including snaps in CRAN submissions?
The text was updated successfully, but these errors were encountered: