You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new control in the storybook decorator that helps the user change the language/locale.
In order to leverage the interaction of sp-theme and LanguageResolutionController in the storybook it is needed to use a workaround similar to requestAnimationFrame so that the story functions get called after the Theme's constructor.
For more context please check out this PR comment.
Motivation and context
Currently if a component is reactive to locale/language changes, in order for the storybook to reflect that it is needed for multiple stories to be created. This doesn't scale as well and it's also cumbersome for users of the SWC storybook to clearly identify the differences between locales.
Currently the most notable behavior change is in the sp-number-field component.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.
It looks like on iPad and mobile the user has a hard time using these controls from the Storybook decorator. Should we place some of them in a Action Menu?
There seems to be an inconsistent behavior: when you toggle "Reduce motion," the picker displays "Locale" instead of the selected value. Could you please check what's causing this? :)
There seems to be an inconsistent behavior: when you toggle "Reduce motion," the picker displays "Locale" instead of the selected value. Could you please check what's causing this? :)
Thank you for looking into this. Missed a small break in the switch case. It should be fixed now. 🚀
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mizgaionutalexandru
changed the title
Description
This PR adds a new control in the storybook decorator that helps the user change the language/locale.
In order to leverage the interaction of
sp-themeandLanguageResolutionControllerin the storybook it is needed to use a workaround similar torequestAnimationFrameso that the story functions get called after theTheme's constructor.For more context please check out this PR comment.
Motivation and context
Currently if a component is reactive to locale/language changes, in order for the storybook to reflect that it is needed for multiple stories to be created. This doesn't scale as well and it's also cumbersome for users of the SWC storybook to clearly identify the differences between locales.
Currently the most notable behavior change is in the
sp-number-fieldcomponent.How has this been tested?
Test case 1
sp-number-fieldstorybookTest case 1
sp-number-fieldstorybookDid it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.