fix(tabs): prevent vertical auto scroll #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Tachometer resultsChrometabs permalinkbasic-test
top-nav permalinkbasic-test
Firefoxtabs permalinkbasic-test
top-nav permalinkbasic-test
|
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
blunteshwar
approved these changes
Jul 19, 2024
1 task
Rajdeepc
added a commit
that referenced
this pull request
Aug 2, 2024
* chore(tabs): updated tabs overflow to fix scroll into view for horizontal scroll * chore(tabs): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com>
Rajdeepc
added a commit
that referenced
this pull request
Aug 2, 2024
* chore(tabs): updated tabs overflow to fix scroll into view for horizontal scroll * chore(tabs): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com>
Rajdeepc
added a commit
that referenced
this pull request
Aug 2, 2024
* chore(tabs): updated tabs overflow to fix scroll into view for horizontal scroll * chore(tabs): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possible fix for #4590
The problem with
scrollIntoViewis that we can not specify the direction of scroll, therefore it scrolls vertically as well, and the function is called all the time, even if you don't actually need to scroll.This implementation provides an alternative, with validations before scrolling, but unfortunately a lot of checks needed (RTL / LTR, take into account the space between the Tabs and the arrows).
Related issue(s)
Motivation and context
Replaces
scrollIntoViewwith calculations based of scroll offsets.A follow-up of #4032.
How has this been tested?
selectedcontrol, enter the number of a tab which is not visible.containerclass amargin-top of 1000px, or whatever value is needed so that the tabs are no longer into viewselectedcontrol, change theselectedvalue, you can choose a number from 1 to 20selectedcontrol, enter the number of a tab which is not visibleScreenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.