fix(slider,overlay): ensure that pointer events in Slider are handled as expected in Overlay #4438

Westbrook · 2024-05-09T21:46:21Z

Description

First, the pointerdownPath was being persisted past the subsequent pointerup event, in some cases, causing the Overlay Stack to act in a strange way

Second, the pointerdown event was being prevented in Slider so that it would not populate a new pointerdownPath over the stale value, causing the Overlay to close.

Related issue(s)

fixes [Bug]: Clicking on a slider track in a popover shouldn't close the popover #4406

How has this been tested?

Test case 1
1. Go here
2. Open the Overlay
3. Click on the track of the Slider to change its value
4. See that the Overlay is not closed

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

… as expected in Overlay

github-actions · 2024-05-09T21:48:27Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions · 2024-05-09T21:50:48Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	222.064 kB	210.238 kB 🏆	210.336 kB
Scripts	54.112 kB	48.104 kB	48.07 kB 🏆
Stylesheet	35.126 kB	30.303 kB 🏆	30.437 kB
Document	5.917 kB	5.185 kB	5.178 kB 🏆
Font	126.909 kB	126.646 kB 🏆	126.651 kB

Request Count

Category	Latest	Main	Branch
Total	45	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

github-actions · 2024-05-09T22:24:41Z

Tachometer results

Chrome

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	484 kB	48.38ms - 49.47ms	-	faster ✔ 3% - 6% 1.42ms - 3.27ms
branch	472 kB	50.52ms - 52.02ms	slower ❌ 3% - 7% 1.42ms - 3.27ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	646 kB	131.29ms - 135.57ms	-	faster ✔ 4% - 8% 5.92ms - 11.42ms
branch	634 kB	140.37ms - 143.83ms	slower ❌ 4% - 9% 5.92ms - 11.42ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	603 kB	61.18ms - 62.51ms	-	faster ✔ 6% - 9% 3.96ms - 6.18ms
branch	591 kB	66.03ms - 67.81ms	slower ❌ 6% - 10% 3.96ms - 6.18ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	602 kB	59.50ms - 60.82ms	-	faster ✔ 4% - 7% 2.80ms - 4.79ms
branch	590 kB	63.21ms - 64.70ms	slower ❌ 5% - 8% 2.80ms - 4.79ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	1872.98ms - 1876.01ms	-	unsure 🔍 -0% - +0% -1.92ms - +1.95ms
branch	777 kB	1873.28ms - 1875.68ms	unsure 🔍 -0% - +0% -1.95ms - +1.92ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	787 kB	1858.48ms - 1861.78ms	-	unsure 🔍 -0% - +0% -2.16ms - +2.21ms
branch	775 kB	1858.67ms - 1861.54ms	unsure 🔍 -0% - +0% -2.21ms - +2.16ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	709 kB	36.94ms - 37.65ms	-	faster ✔ 1% - 4% 0.55ms - 1.51ms
branch	697 kB	38.00ms - 38.65ms	slower ❌ 1% - 4% 0.55ms - 1.51ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	709 kB	393.90ms - 403.62ms	-	faster ✔ 4% - 7% 14.91ms - 29.55ms
branch	697 kB	415.52ms - 426.46ms	slower ❌ 4% - 7% 14.91ms - 29.55ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	476 kB	220.55ms - 227.31ms	-	faster ✔ 1% - 4% 1.19ms - 9.97ms
branch	463 kB	226.71ms - 232.32ms	slower ❌ 1% - 4% 1.19ms - 9.97ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	685 kB	421.01ms - 425.25ms	-	faster ✔ 0% - 2% 1.45ms - 7.24ms
branch	662 kB	425.50ms - 429.44ms	slower ❌ 0% - 2% 1.45ms - 7.24ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	779 kB	21.70ms - 22.11ms	-	faster ✔ 8% - 11% 1.91ms - 2.58ms
branch	780 kB	23.89ms - 24.42ms	slower ❌ 9% - 12% 1.91ms - 2.58ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	761 kB	342.56ms - 346.99ms	-	faster ✔ 2% - 3% 5.87ms - 12.05ms
branch	750 kB	351.59ms - 355.89ms	slower ❌ 2% - 4% 5.87ms - 12.05ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	561 kB	39.99ms - 40.89ms	-	faster ✔ 5% - 8% 2.05ms - 3.48ms
branch	549 kB	42.65ms - 43.76ms	slower ❌ 5% - 9% 2.05ms - 3.48ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	513 kB	511.49ms - 520.16ms	-	faster ✔ 2% - 4% 8.35ms - 21.40ms
branch	500 kB	525.82ms - 535.57ms	slower ❌ 2% - 4% 8.35ms - 21.40ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	383 kB	11.44ms - 11.60ms	-	faster ✔ 2% - 4% 0.25ms - 0.49ms
branch	372 kB	11.80ms - 11.98ms	slower ❌ 2% - 4% 0.25ms - 0.49ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	480 kB	75.49ms - 77.56ms	-	faster ✔ 3% - 7% 2.38ms - 5.86ms
branch	467 kB	79.25ms - 82.04ms	slower ❌ 3% - 8% 2.38ms - 5.86ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	722 kB	1859.51ms - 1863.28ms	-	unsure 🔍 -0% - +0% -5.09ms - +0.63ms
branch	710 kB	1861.47ms - 1865.78ms	unsure 🔍 -0% - +0% -0.63ms - +5.09ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	557 kB	33.37ms - 34.06ms	-	faster ✔ 3% - 6% 1.01ms - 2.13ms
branch	548 kB	34.84ms - 35.73ms	slower ❌ 3% - 6% 1.01ms - 2.13ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	535 kB	23.03ms - 23.83ms	-	faster ✔ 6% - 10% 1.41ms - 2.53ms
branch	521 kB	25.01ms - 25.78ms	slower ❌ 6% - 11% 1.41ms - 2.53ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	654 kB	51.16ms - 52.13ms	-	faster ✔ 5% - 9% 2.99ms - 4.81ms
branch	643 kB	54.77ms - 56.31ms	slower ❌ 6% - 9% 2.99ms - 4.81ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	631 kB	41.59ms - 42.52ms	-	faster ✔ 6% - 9% 2.71ms - 4.12ms
branch	619 kB	44.94ms - 45.99ms	slower ❌ 6% - 10% 2.71ms - 4.12ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	527 kB	55.71ms - 57.36ms	-	faster ✔ 2% - 6% 1.26ms - 3.51ms
branch	516 kB	58.16ms - 59.69ms	slower ❌ 2% - 6% 1.26ms - 3.51ms	-

Firefox

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	484 kB	114.04ms - 119.88ms	-	faster ✔ 0% - 7% 0.31ms - 8.25ms
branch	472 kB	118.55ms - 123.93ms	slower ❌ 0% - 7% 0.31ms - 8.25ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	646 kB	275.48ms - 279.04ms	-	faster ✔ 12% - 14% 38.08ms - 43.48ms
branch	634 kB	316.01ms - 320.07ms	slower ❌ 14% - 16% 38.08ms - 43.48ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	603 kB	130.63ms - 132.61ms	-	unsure 🔍 -2% - +0% -2.41ms - +0.01ms
branch	591 kB	132.13ms - 133.51ms	unsure 🔍 -0% - +2% -0.01ms - +2.41ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	602 kB	154.88ms - 160.16ms	-	slower ❌ 10% - 15% 14.32ms - 21.36ms
branch	590 kB	137.35ms - 142.01ms	faster ✔ 9% - 13% 14.32ms - 21.36ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	1909.40ms - 1919.72ms	-	slower ❌ 1% - 2% 23.57ms - 34.59ms
branch	777 kB	1883.53ms - 1887.43ms	faster ✔ 1% - 2% 23.57ms - 34.59ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	787 kB	1884.11ms - 1888.65ms	-	unsure 🔍 -0% - +0% -2.98ms - +3.54ms
branch	775 kB	1883.76ms - 1888.44ms	unsure 🔍 -0% - +0% -3.54ms - +2.98ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	709 kB	60.88ms - 63.44ms	-	unsure 🔍 -3% - +2% -1.63ms - +1.23ms
branch	697 kB	61.71ms - 63.01ms	unsure 🔍 -2% - +3% -1.23ms - +1.63ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	709 kB	752.69ms - 764.43ms	-	slower ❌ 2% - 5% 17.72ms - 37.36ms
branch	697 kB	723.14ms - 738.90ms	faster ✔ 2% - 5% 17.72ms - 37.36ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	476 kB	433.97ms - 446.19ms	-	faster ✔ 0% - 4% 1.46ms - 18.22ms
branch	463 kB	444.18ms - 455.66ms	slower ❌ 0% - 4% 1.46ms - 18.22ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	768 kB	645.46ms - 664.50ms	-	slower ❌ 2% - 5% 9.87ms - 30.89ms
branch	757 kB	630.15ms - 639.05ms	faster ✔ 2% - 5% 9.87ms - 30.89ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	771 kB	47.05ms - 47.83ms	-	faster ✔ 4% - 6% 1.75ms - 3.13ms
branch	761 kB	49.31ms - 50.45ms	slower ❌ 4% - 7% 1.75ms - 3.13ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	761 kB	669.01ms - 677.15ms	-	slower ❌ 3% - 5% 19.48ms - 30.80ms
branch	750 kB	644.01ms - 651.87ms	faster ✔ 3% - 5% 19.48ms - 30.80ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	561 kB	94.12ms - 101.16ms	-	unsure 🔍 -4% - +4% -3.51ms - +3.99ms
branch	549 kB	96.11ms - 98.69ms	unsure 🔍 -4% - +4% -3.99ms - +3.51ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	513 kB	1028.77ms - 1038.11ms	-	faster ✔ 5% - 8% 52.74ms - 85.70ms
branch	500 kB	1086.85ms - 1118.47ms	slower ❌ 5% - 8% 52.74ms - 85.70ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	383 kB	30.96ms - 34.88ms	-	unsure 🔍 -8% - +11% -2.59ms - +3.55ms
branch	372 kB	30.08ms - 34.80ms	unsure 🔍 -11% - +8% -3.55ms - +2.59ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	480 kB	165.35ms - 172.65ms	-	faster ✔ 1% - 7% 1.69ms - 12.87ms
branch	467 kB	172.05ms - 180.51ms	slower ❌ 1% - 8% 1.69ms - 12.87ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	722 kB	1878.46ms - 1882.06ms	-	unsure 🔍 -0% - +0% -4.83ms - +1.23ms
branch	710 kB	1879.63ms - 1884.49ms	unsure 🔍 -0% - +0% -1.23ms - +4.83ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	654 kB	80.83ms - 84.37ms	-	slower ❌ 9% - 15% 6.57ms - 10.71ms
branch	643 kB	72.87ms - 75.05ms	faster ✔ 8% - 13% 6.57ms - 10.71ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	533 kB	46.90ms - 47.98ms	-	faster ✔ 18% - 26% 10.52ms - 16.24ms
branch	521 kB	58.01ms - 63.63ms	slower ❌ 22% - 34% 10.52ms - 16.24ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	654 kB	116.39ms - 123.17ms	-	faster ✔ 1% - 8% 1.39ms - 9.61ms
branch	643 kB	122.94ms - 127.62ms	slower ❌ 1% - 8% 1.39ms - 9.61ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	631 kB	93.64ms - 97.64ms	-	faster ✔ 6% - 11% 6.01ms - 12.11ms
branch	619 kB	102.40ms - 107.00ms	slower ❌ 6% - 13% 6.01ms - 12.11ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	527 kB	101.54ms - 108.02ms	-	faster ✔ 0% - 9% 0.14ms - 9.46ms
branch	516 kB	106.23ms - 112.93ms	slower ❌ 0% - 9% 0.14ms - 9.46ms	-

packages/overlay/stories/overlay-element.stories.ts

spdev3000

lgtm

fix(slider,overlay): ensure that pointer events in Slider are handled…

33253b3

… as expected in Overlay

Westbrook requested review from spdev3000 and a team May 9, 2024 21:46

spdev3000 reviewed May 10, 2024

View reviewed changes

packages/overlay/stories/overlay-element.stories.ts Outdated Show resolved Hide resolved

spdev3000 previously approved these changes May 10, 2024

View reviewed changes

Westbrook dismissed spdev3000’s stale review via 154bc02 May 10, 2024 11:48

chore: code review suggestion

154bc02

Westbrook merged commit db193e8 into main May 10, 2024
48 checks passed

Westbrook deleted the overlay-slider branch May 10, 2024 12:19

fix(slider,overlay): ensure that pointer events in Slider are handled as expected in Overlay #4438

fix(slider,overlay): ensure that pointer events in Slider are handled as expected in Overlay #4438

Conversation

Westbrook commented May 9, 2024

Description

Related issue(s)

How has this been tested?

Types of changes

Checklist

github-actions bot commented May 9, 2024

Branch preview

github-actions bot commented May 9, 2024 • edited Loading

Lighthouse scores

Transfer Size

Request Count

github-actions bot commented May 9, 2024 • edited Loading

Tachometer results

action-bar permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

combobox permalink

basic-test

light-dom-test permalink

menu permalink

test-basic

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker permalink

basic-test

popover permalink

test-basic

slider permalink

test-basic

split-button permalink

basic-test

tooltip permalink

test-basic

test-directive permalink

test-element permalink

test-lazy permalink

truncated permalink

basic-test

action-bar permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

combobox permalink

basic-test

light-dom-test permalink

menu permalink

test-basic

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker permalink

basic-test

popover permalink

test-basic

slider permalink

test-basic

split-button permalink

basic-test

tooltip permalink

test-basic

test-directive permalink

test-element permalink

github-actions bot commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024 •

edited

Loading