Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Quiet Picker has incorrect hover effect #4166

Closed
1 task done
Rocss opened this issue Mar 12, 2024 · 0 comments · Fixed by #4167
Closed
1 task done

[Bug]: Quiet Picker has incorrect hover effect #4166

Rocss opened this issue Mar 12, 2024 · 0 comments · Fixed by #4167
Assignees
Labels
bug Something isn't working Component: Picker triage An issue needing triage

Comments

@Rocss
Copy link
Contributor

Rocss commented Mar 12, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-picker

Expected behavior

Spectrum CSS: Quiet XL Picker -> hover
Screenshot 2024-03-12 at 11 28 11

Actual behavior

SWC: Quiet XL Picker -> hover
Screenshot 2024-03-12 at 11 26 08

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/picker/
  2. Click on "Size" and select XL or L
  3. Select "Quiet"
  4. Hover over the Picker
  5. See the background color being applied

Sample code that illustrates the problem

Seems like the problem is that the CSS for the quiet variant of the sp-picker was not correctly processed:

:host([open]) #button:not(.spectrum-Picker--quiet) {

observe the spectrum-Picker--quiet class which should be translated to the HTML quiet attribute.

Also, in the storybook, the sp-label-field should have the same size as the sp-picker, or else it looks weird and the sp-picker climbs over the sp-label-field

Logs taken while reproducing problem

No response

@Rocss Rocss added bug Something isn't working triage An issue needing triage labels Mar 12, 2024
@Rocss Rocss self-assigned this Mar 12, 2024
@Rocss Rocss linked a pull request Mar 12, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Picker triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant