chore(slider): slider handle alignment fix #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
added
bug
1 task
Tachometer resultsChromeslider permalink
Firefoxslider permalink
|
Westbrook
reviewed
Dec 8, 2023
| @@ -616,7 +616,7 @@ governing permissions and limitations under the License. | |||
| ); | |||
| z-index: 0; | |||
| } | |||
| .ticks ~ .spectrum-Slider-handleContainer .handle { | |||
| .ticks ~ .handleContainer .handle { | |||
| background: var( | |||
| --mod-slider-ticks-handle-background-color, | |||
| var(--spectrum-slider-ticks-handle-background-color) | |||
There was a problem hiding this comment.
This value doesn't seem to be available, yet:
Vs the CSS implementation:
See the "tick" sticking through.
Do we maybe need to update @spectrum-css/tokens as part of this change? Or report missing values back to CSS?
There was a problem hiding this comment.
background color property in handleController.ts was overriding the tick css. Should be solved now
added 2 commits
December 11, 2023 12:07
Westbrook
reviewed
Dec 11, 2023
Rajdeepc
force-pushed
the
bug/slider-ui
branch
from
7c6d9ea to
de25ec8
Compare
1 task
|
Also, can you see if this addresses #3536 in a material way? |
Rajdeepc
force-pushed
the
bug/slider-ui
branch
from
c2e4bde to
0726ebb
Compare
1 task
Westbrook
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added DOM changes to bring in the handleContainer and trackContainer
Related issue(s)
*-handle-border-color-*CSS variables are not taken into account #3536Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.