feat(action-button): allow change events to bubble and pierce shadowdom #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickschaap
force-pushed
the
change-bubble
branch
from
6cff0ab to
e7ef339
Compare
1 task
nickschaap
changed the title
nickschaap
force-pushed
the
change-bubble
branch
from
e7ef339 to
46f173e
Compare
Tachometer resultsChromeaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
menu permalink
number-field permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
menu permalink
number-field permalink
overlay permalink
picker permalink
popover permalink
slider permalink
split-button permalink
tooltip permalink
|
Westbrook
reviewed
Sep 6, 2023
| @@ -363,6 +363,7 @@ export class ActionGroup extends SizedMixin(SpectrumElement, { | |||
|
|
|||
| private manageChildren(changes?: PropertyValues): void { | |||
| this.buttons.forEach((button) => { | |||
| button.toggles = false; | |||
There was a problem hiding this comment.
This could cause an issue when a consumer leverages an Action Group without selects but Action Buttons with toggles in order to manage the selection of elements in the group via some custom algorithm.
I think with the change to Action Button, that we want to move away from listened on click and to listening on change and then event.stopPropagation()ing the child event. Much like we see in Radio Group.
There was a problem hiding this comment.
@Westbrook Does that mean we want to dispatch a change event for all clicks on action buttons? Currently change events are only dispatched for action buttons that toggle.
There was a problem hiding this comment.
Indeed, this is a bit more complex than Radio Group.
The context is that if the Action Group should dispatch change events (selects === 'single' | 'multiple') we shouldn't prevent child Action Buttons from dispatching change events (button.toggles = false;). In that context we should listen for those change events and event.stopPropagation() on them. We likely also want to event.preventDefault() them, as the Action Button is a controller component of the Action Group in that case and does not get to determine its own state.
Does that make next steps here clear enough?
Westbrook
force-pushed
the
change-bubble
branch
from
46f173e to
bc7b8a0
Compare
Westbrook
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
@nickschaap, made a couple of changes and think this is OK to land. Can you confirm whether you think this would cover your original use case before we merge?
|
@Westbrook LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Action button change events should bubble and be composed to match behavior with other SWC components which fire change events such as
sp-switchandsp-checkboxRelated issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.