From e7ef33947e6a3c3f5e2ff3d903f40a6cfd738fe5 Mon Sep 17 00:00:00 2001 From: Nick Schaap Date: Fri, 1 Sep 2023 17:31:21 -0400 Subject: [PATCH] fix(action-button): allow change events to bubble and pierce shadowdom fix: remove unused code fix(action-button): allow change events to bubble and pierce shadowdom --- packages/action-button/src/ActionButton.ts | 2 ++ packages/action-group/src/ActionGroup.ts | 1 + yarn.lock | 8 ++++---- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/action-button/src/ActionButton.ts b/packages/action-button/src/ActionButton.ts index 5651c09dc4..b88858d19b 100644 --- a/packages/action-button/src/ActionButton.ts +++ b/packages/action-button/src/ActionButton.ts @@ -127,6 +127,8 @@ export class ActionButton extends SizedMixin(ButtonBase, { const applyDefault = this.dispatchEvent( new Event('change', { cancelable: true, + bubbles: true, + composed: true, }) ); if (!applyDefault) { diff --git a/packages/action-group/src/ActionGroup.ts b/packages/action-group/src/ActionGroup.ts index 991b8cf79e..d845b1cff6 100644 --- a/packages/action-group/src/ActionGroup.ts +++ b/packages/action-group/src/ActionGroup.ts @@ -363,6 +363,7 @@ export class ActionGroup extends SizedMixin(SpectrumElement, { private manageChildren(changes?: PropertyValues): void { this.buttons.forEach((button) => { + button.toggles = false; if (this.quiet || changes?.get('quiet')) { button.quiet = this.quiet; } diff --git a/yarn.lock b/yarn.lock index e7c73e1c75..f0d497caa8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5573,10 +5573,10 @@ resolved "https://registry.yarnpkg.com/@spectrum-css/tag/-/tag-6.0.1.tgz#b35d24085983b14768a3ad76b03ec281fb49eadf" integrity sha512-Fsbfa3VufWvO4zWFxoTdxgXoXFa5ooSZS7sTojX72jTLsnt8JSfZOJUJDehuWcuJCOweRCDlwVlSrZKvoZOUkQ== -"@spectrum-css/taggroup@^4.0.0-beta.0": - version "4.0.0-beta.0" - resolved "https://registry.yarnpkg.com/@spectrum-css/taggroup/-/taggroup-4.0.0-beta.0.tgz#13ad9df866db267486ef44d3e9f2a21e5b4ada88" - integrity sha512-Z19nIL5FyLDftRIkgL/TA5vJy7Zas086eFKe9UMgFw2J9CmMCINOBjuDLewFGnVYntDIQ0nW+3k+IW5M3+kVAg== +"@spectrum-css/taggroup@^4.0.0": + version "4.0.3" + resolved "https://registry.yarnpkg.com/@spectrum-css/taggroup/-/taggroup-4.0.3.tgz#d9a868bbb09eccc2403627f118c7001136a0cbce" + integrity sha512-YEVMtm+QzehHFDt/bQXJP3/XLV+4xAVKX4FVgJq0Cf7AWwNWEhInWJOpQGN0GlyemdqaNmi0IQSapNGtxdFWRQ== "@spectrum-css/textfield@^6.0.11": version "6.0.11"