Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequential and diverging palettes #2

Closed
NateBaldwinDesign opened this issue Dec 6, 2019 · 2 comments · Fixed by #155
Closed

Add sequential and diverging palettes #2

NateBaldwinDesign opened this issue Dec 6, 2019 · 2 comments · Fixed by #155
Assignees
Labels
enhancement New feature or request npm packages Issues related to the leonardo npm packages UI Issues related to the Leonardo web interface

Comments

@NateBaldwinDesign
Copy link
Collaborator

NateBaldwinDesign commented Dec 6, 2019

Add support for sequential and diverging palettes.

Each type would need unique configs for setup. Sequential would need:

  • Shift input (exponential slider)
  • Clamping option (full black/white or only key colors)
  • Number of colors to output

Diverging would need:

  • Shift input
  • Clamping
  • Number inputs
  • Unique gradient & separate inputs for each side of the diverging scale

See branch: https://github.com/adobe/leonardo/blob/sequential-colors/packages/ui/src/index.js

@NateBaldwinDesign NateBaldwinDesign added the enhancement New feature or request label Dec 6, 2019
@NateBaldwinDesign NateBaldwinDesign added UI Issues related to the Leonardo web interface and removed enhancement New feature or request labels Dec 6, 2019
@NateBaldwinDesign NateBaldwinDesign self-assigned this Dec 12, 2019
@NateBaldwinDesign NateBaldwinDesign added npm packages Issues related to the leonardo npm packages enhancement New feature or request labels Dec 19, 2019
@NateBaldwinDesign
Copy link
Collaborator Author

Here is a prototype for sequential scale manipulation: https://codepen.io/NateBaldwinDesign/full/mdJqKpP

Features:

  1. Clamping color values to input only
  2. No clamping = adds black & white to color scale
  3. Correct lightness = implements Leonardo's current method of dynamic domains based on key color lightness values.
  4. No corrected lightness = simple implement by which each color is equally spaced in the domain range.

@NateBaldwinDesign
Copy link
Collaborator Author

Current WIP on this branch fails tests by single hexidecimal values due to update in method for outputting colors (incrementally rather than using d3.range() function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request npm packages Issues related to the leonardo npm packages UI Issues related to the Leonardo web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant