Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional custom headers field #149

Merged
merged 1 commit into from
Apr 6, 2023
Merged

feat: add optional custom headers field #149

merged 1 commit into from
Apr 6, 2023

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Apr 6, 2023

Having the capability to provide custom headers to the request made to fetch the remote server content might be required: for certain JSON API request, we need to pass an header token.

@kptdobe kptdobe requested a review from catalan-adobe April 6, 2023 10:04
Copy link
Collaborator

@catalan-adobe catalan-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A little example in the guidelines would be nice :)

@kptdobe kptdobe merged commit 022ade2 into main Apr 6, 2023
@kptdobe kptdobe deleted the custom-headers branch April 6, 2023 11:38
github-actions bot pushed a commit that referenced this pull request Apr 6, 2023
# [1.35.0](v1.34.2...v1.35.0) (2023-04-06)

### Features

* add optional custom headers field ([#149](#149)) ([022ade2](022ade2))
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kptdobe added a commit that referenced this pull request Apr 6, 2023
@kptdobe
Copy link
Contributor Author

kptdobe commented Apr 6, 2023

github-actions bot pushed a commit that referenced this pull request Apr 6, 2023
## [1.35.1](v1.35.0...v1.35.1) (2023-04-06)

### Reverts

* Revert "feat: add optional custom headers field (#149)" ([2abc82f](2abc82f)), closes [#149](#149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants