Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QoL - Remove empty lines in html preview #113

Merged
merged 6 commits into from
Mar 13, 2023

Conversation

catalan-adobe
Copy link
Collaborator

@catalan-adobe catalan-adobe commented Feb 9, 2023

Quality of Life: improve HTML preview

From

<main>
    <table>
        <tr>
            <th colspan="2">marquee (small, light)</th>
        </tr>
        <tr>
            <td colspan="2">#f5f5f5</td>
        </tr>
        <tr>
            <td>
                <h6>REPORT</h6>
                <h1>The heart of IT transformation for</h1>
            </td>
            <td></td>
        </tr>
    </table>---<table>
        <tr>
            <th colspan="2">Columns (contained)</th>
        </tr>
        <tr>
            <td>
                <div class="flex_2016368841 flex aem-GridColumn aem-GridColumn--default--12">




                    <div id="root_flex_2016368841" class="dexter-FlexContainer  
     
     
     
      
     
     ">










                        <div class="dexter-FlexContainer-Items   dexter-FlexContainer--mobileJustifyCenter dexter-FlexContainer--mobileAlignItemCenter dexter-FlexContainer--mobileAlignContentCenter dexter-FlexContainer--mobileAlignItemContentCenter">





                            <div class="flex">




                                <div id="root_flex_2016368841_items_flex_copy_1663389260" class="dexter-FlexContainer  
     
     
     
      
     
     " style="background-image: url(&quot;http://localhost:3001/content/dam/dx/us/en/resources/webinars/prototype/webinar-on-demand-under-marquee-bar-1440x45.jpg.img.jpg&quot;);">










                                    <div class="dexter-FlexContainer-Items   dexter-FlexContainer--mobileJustifyCenter dexter-FlexContainer--mobileAlignItemCenter dexter-FlexContainer--mobileAlignContentCenter dexter-FlexContainer--mobileAlignItemContentCenter dexter-FlexContainer--tabletJustifyCenter dexter-FlexContainer--tabletAlignItemCenter dexter-FlexContainer--tabletAlignContentCenter dexter-FlexContainer--tabletAlignItemContentCenter">

To

<main>
    <table>
        <tr>
            <th colspan="2">marquee (small, light)</th>
        </tr>
        <tr>
            <td colspan="2">#f5f5f5</td>
        </tr>
        <tr>
            <td>
                <h6>REPORT</h6>
                <h1>The heart of IT transformation for</h1>
            </td>
            <td></td>
        </tr>
    </table>---<table>
        <tr>
            <th colspan="2">Columns (contained)</th>
        </tr>
        <tr>
            <td>
                <div class="flex_2016368841 flex aem-GridColumn aem-GridColumn--default--12">
                    <div id="root_flex_2016368841" class="dexter-FlexContainer ">
                        <div class="dexter-FlexContainer-Items dexter-FlexContainer--mobileJustifyCenter dexter-FlexContainer--mobileAlignItemCenter dexter-FlexContainer--mobileAlignContentCenter dexter-FlexContainer--mobileAlignItemContentCenter">
                            <div class="flex">
                                <div id="root_flex_2016368841_items_flex_copy_1663389260" class="dexter-FlexContainer " style="background-image: url(&quot;http://localhost:3001/content/dam/dx/us/en/resources/webinars/prototype/webinar-on-demand-under-marquee-bar-1440x45.jpg.img.jpg&quot;);">
                                    <div class="dexter-FlexContainer-Items dexter-FlexContainer--mobileJustifyCenter dexter-FlexContainer--mobileAlignItemCenter dexter-FlexContainer--mobileAlignContentCenter dexter-FlexContainer--mobileAlignItemContentCenter dexter-FlexContainer--tabletJustifyCenter dexter-FlexContainer--tabletAlignItemCenter dexter-FlexContainer--tabletAlignContentCenter dexter-FlexContainer--tabletAlignItemContentCenter">

@catalan-adobe catalan-adobe requested a review from kptdobe February 9, 2023 16:30
@catalan-adobe catalan-adobe changed the title Remove empty lines in html preview QoL - Remove empty lines in html preview Feb 10, 2023
@catalan-adobe catalan-adobe changed the title QoL - Remove empty lines in html preview feat: QoL - Remove empty lines in html preview Feb 10, 2023
@kptdobe kptdobe merged commit d7585c6 into main Mar 13, 2023
@kptdobe kptdobe deleted the optimize-html-in-preview-tab branch March 13, 2023 10:53
github-actions bot pushed a commit that referenced this pull request Mar 13, 2023
# [1.33.0](v1.32.1...v1.33.0) (2023-03-13)

### Features

* remove empty lines in html preview ([#113](#113)) ([d7585c6](d7585c6))
@github-actions
Copy link

🎉 This PR is included in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants