Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve authentication implementation #90

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Conversation

tripodsan
Copy link
Contributor

@tripodsan tripodsan commented Jun 24, 2022

  • use x-forwarded-host correctly to determine initial request url
  • use PKI public key export instead of JWK to support fastly's rsa_digest
  • use state.env instead of process.env for oauth credentials / secrets (fixes process.env not available in cloudflare worker #85)

@github-actions
Copy link

This PR will trigger a patch release when merged.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #90 (9866e0d) into main (561c604) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3878      3906   +28     
=========================================
+ Hits          3878      3906   +28     
Impacted Files Coverage Δ
src/PipelineState.js 100.00% <100.00%> (ø)
src/steps/authenticate.js 100.00% <100.00%> (ø)
src/utils/auth.js 100.00% <100.00%> (ø)
src/utils/idp-configs/microsoft.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561c604...9866e0d. Read the comment docs.

@tripodsan tripodsan merged commit def347c into main Jun 24, 2022
@tripodsan tripodsan deleted the fix-x-fwd-host-again branch June 24, 2022 14:44
github-actions bot pushed a commit that referenced this pull request Jun 24, 2022
# [3.1.0](v3.0.2...v3.1.0) (2022-06-24)

### Features

* improve authentication implementation ([#90](#90)) ([def347c](def347c)), closes [#85](#85)
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process.env not available in cloudflare worker
2 participants