fix: ensure contentBusId is loaded properly #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 4308 4329 +21
=========================================
+ Hits 4308 4329 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tripodsan
commented
Jul 1, 2023
| @@ -98,7 +98,6 @@ async function computeSurrogateKeys(path, contentBusId) { | |||
| export async function jsonPipe(state, req) { | |||
| const { log } = state; | |||
| state.type = 'json'; | |||
| const { contentBusId } = state; | |||
There was a problem hiding this comment.
@stefan-guggisberg this was the cause of the wrong surrogate key
tripodsan
commented
Jul 1, 2023
| await fetchConfigAll(state, request, response); | ||
| await setCustomResponseHeaders(state, request, response); | ||
| try { | ||
| await fetchConfig(state, request); |
There was a problem hiding this comment.
this was completely missing! OPTIONS requests would have never worked properly
tripodsan
commented
Jul 1, 2023
| @@ -46,7 +46,6 @@ declare interface PipelineOptions { | |||
| ref: string; | |||
| partition: string; | |||
| path: string; | |||
| contentBusId: string; | |||
There was a problem hiding this comment.
remove it from options, so that it isn't set accidentally
stefan-guggisberg
approved these changes
Jul 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
## [3.11.18](v3.11.17...v3.11.18) (2023-07-04) ### Bug Fixes * ensure contentBusId is loaded properly ([#342](#342)) ([80e4552](80e4552))
|
🎉 This PR is included in version 3.11.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contentBusIdfrom PipelineStateOptions (constructor)contentBusIdis loaded from helix-config in all pipes