Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Toggle Block Comment selection is inconsistent with multiple line selections #7495

Open
njx opened this issue Apr 12, 2014 · 3 comments
Open
Assignees

Comments

@njx
Copy link

njx commented Apr 12, 2014

  1. Open a JS file
  2. Create two cursors (using Cmd-click) on two lines that aren't adjacent
  3. Ctrl-L to select both lines
  4. Cmd-Alt-/ to block comment

Result: The first selection expands to include the end comment line, which it shouldn't. The second selection is correct.

@njx
Copy link
Author

njx commented Apr 12, 2014

This is probably a bug in how the comment logic was modified to handle multiple selections, not a bug in the comment logic itself. It reproduces both in master and in #7135.

/cc @TomMalbran - don't think you need to do anything about this but thought you might be interested.

@pthiess
Copy link
Contributor

pthiess commented Apr 13, 2014

@TomMalbran -- I took the liberty to assign this to you without knowing whether you're truly interested, please feel free to reassign to @njx anytime.

Thanks a ton!

@TomMalbran
Copy link
Contributor

@njx wrote the part that made it work with multiple cursors and I don't fully understand how it works. I would need to understand the code first. I guess it might be better if @njx fixed this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants