Replace "OK" with "Done" for Project Settings Dialog

[larz0]

"Save" is much more appropriate.

[peterflynn]

@larz0 Or "Done" maybe? Seems like settings-editing often uses that term nowadays...

[larz0]

Ahh "Done" is not bad either.

[njx]

I think I'd prefer "Done", since in the context of a code editor "Save" has a pretty specific meaning.

That said, this feels to me like one of those desktop-vs-web things...on the desktop, people are really used to "OK" for confirming settings in modal dialogs.

[larz0]

I'm going to change the issue from "Save" to "Done".

[TomMalbran]

We use OK a lot, we should check when to use Done and when to use OK, or should we replace OK with Done in all the dialogs?

[larz0]

If there's "Cancel" right next to "OK" then we should probably replace it with "Done" when there are form elements in the dialog.

[njx]

Low pri to @larz0 - to either fix it yourself :), or at least assess which dialogs need to be changed.

Note that in Extension Manager we use "Close", but that's not really a settings dialog. Conversely, in things like Preferences on the Mac, the dialogs are nonmodal to begin with - settings are generally applied immediately, except in special cases like Network preferences, and you can't "cancel" to get back to previous settings. I wonder if we would want to consider going that route.

[larz0]

Ok sounds good, I'll take a crack at it.

[lallmon]

I changed the button in the dialog for Project Settings to "Done", but wanted to check with @larz0 if any more need to be changed? Or what contexts they would be changed to "Done"?

[larz0]

Thanks @Lucaska did you make a pull request?

[lallmon]

@larz0 Just did. 👍