Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Missing intellisense on too big File #6986

Closed
SeriousM opened this issue Feb 23, 2014 · 6 comments
Closed

Missing intellisense on too big File #6986

SeriousM opened this issue Feb 23, 2014 · 6 comments

Comments

@SeriousM
Copy link

Version: sprint 36 experimental build 0.36.0-11506 (release 942505c)
OS: Win7 x64, english
Extensions: none

Hi, I found a strange bug and I want to share it with you.

I was playing around with the phaser.io framework v1.1.5 and included the not-minified version (phaser.js) of it but I noticed that the intellisense was missing.
bracketserror

After changing to the minified version (phaser.min.js) and a reload of Brackets the intellisense was available.
bracketsok

I was able to switch forth and back several times and the error was reproducible.
Here is the gist to the test.js file.

var game = new Phaser.Game(800, 600, Phaser.AUTO, 'phaser-example', { preload: preload, create: create, update: update });

var s;

function create() {

    game.physics.setBoundsToWorld(true, true, true, false);

    s = game.add.tileSprite(0, 0, 800, 600, 'starfield');

    // auto-complete here:
    s.
}

I think the problem is about the size of the file. I know that the files pf phaser.io are JSLint'ed, therefor the minified version should not emit an error that causes this problem.

The problem is, that I can't produce such a big file to prove it.
I tried to get a console output from Brackets but I failed.

I hope you can reproduce the error.

Best regards and keep up this awesome product!

@dangoor dangoor self-assigned this Mar 3, 2014
@dangoor
Copy link
Contributor

dangoor commented Mar 3, 2014

Medium to me to investigate as part of code hint refactoring and to make sure it's a known issue.

I believe there is a limit in our code hints code on file size that we use to ensure good performance of the editor. I'm going to double check with the info you've given us.

@SeriousM
Copy link
Author

SeriousM commented Mar 3, 2014

Alright, thank you.
I think framework files like that should not be limited by size to avoid
such issues.

@dangoor dangoor added this to the Brackets 1.0 milestone Mar 17, 2014
@dangoor
Copy link
Contributor

dangoor commented Aug 13, 2014

@SeriousM In the current release of Brackets (0.42), there is no longer a file size limit. However, there is a time limit, so if a file takes too long to process, we won't do hints for that file.

@dangoor dangoor closed this as completed Aug 13, 2014
@dangoor
Copy link
Contributor

dangoor commented Aug 13, 2014

Please take a look and let us know if it's working better for you!

@dangoor
Copy link
Contributor

dangoor commented Aug 13, 2014

Correction: the size limit is now 10000 lines (up from 2000) so there is still a size limit but it should catch fewer files.

@SeriousM
Copy link
Author

Works, thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants