This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
FileSystem Implementation (#247) #2158
Merged
+75
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks, Chema. I'm not sure if we can prioritize this for this week. We'll have to take a look again next week. Thanks for your patience. |
|
No problem! It's lowprio/cleanup and you guys seem busy enough. No need to hurry on this one ;) |
|
reviewing |
| @@ -214,6 +214,7 @@ define(function (require, exports, module) { | |||
| // TODO: (issue #241): implement FileEntry.remove() | |||
| // once NativeFileSystem has a delete/unlink, should use that | |||
| brackets.fs.unlink(placeholderPath, function (err) { | |||
| console.log(err); | |||
|
Initial review complete. Just one minor comment. |
|
Oops... fixed! |
|
Thanks, Chema! Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Dec 6, 2012
FileSystem Implementation (#247)
This was referenced Aug 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the
FileSysteminterface described in http://www.w3.org/TR/file-system-api/#the-filesystem-interface and modifiesNativeFileSystem.requestNativeFileSystemto return aFileSystemobject with a rootDirectoryEntryfollowing the specs.As indicated in #247, it also updates all existing calls to
requestNativeFileSystem(tests included) to get the root DirectoryEntry.This is a dangerous change that could potentially break several extensions so we may want to implement this in a more backward compatible manner. However, I've done a global find in all the extensions listed in the wiki and only brackets-snippets seems to be calling
requestNativeFileSystemdirectly, so it looks less disruptive than I originally thought...