-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Status bar mode label weirdly capitalized; uses unfriendly names #1826
Comments
I don't think this should block DoD of the tabs-to-spaces story, since this is essentially a bonus feature that we got with the status bar. However, we should probably fix it before the next Edge Code drop since it's pretty visible. Marking Sprint 16. |
(Another option would be to temporarily remove the mode indicator from the status bar for the Edge Code drop.) |
Assigned to Randy |
I also notice weird behavior for .json mode. It seems to do nothing and continue to display the mode of the previous file. UPDATE: I fixed problem with JSON and other modes. Function editor.getModeForSelection() can return either a string or an Object, but code was assuming it was always a string. |
FBNC to @peterflynn |
This is definitely an improvement, though I'm still seeing many files show names that are odd or incorrectly capitalized:
To really solve this I think we'll just need a hand-written mapping from mode to user-friendly string, rather than programmatic heuristics. But that can probably wait until this story: https://trello.com/card/api-for-extensions-to-add-new-language-syntax-coloring-mode/4f90a6d98f77505d7940ce88/639 |
Also, I still think the default mode's "Text" label should be localized... |
@peterflynn there's already a mapping, so it's easy to add any of these others. |
Looks ok enough for now. I had a few other ideas for cleanup in this area that maybe we could tackle when we get around to #1869. |
#2844 uses the language API for that |
Result:
1: status bar says "javascript" (all lowercase)
2: status bar says "text/plain"
Expected:
1: "JavaScript" (properly capitalized)
2: "Text" or "Plain text" (more user friendly than a raw mimetype)
Other editors like Sublime and TextMate follow the expected pattern.
The text was updated successfully, but these errors were encountered: