Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS: background-blend-mode highlights as incorrect property #11683

Closed
torvalamo opened this issue Sep 10, 2015 · 10 comments
Closed

CSS: background-blend-mode highlights as incorrect property #11683

torvalamo opened this issue Sep 10, 2015 · 10 comments

Comments

@torvalamo
Copy link

Does for some reason not show as a valid css property, despite being in the config file (added last year as far as I could tell) and the code hinting list both for property and allowed values to it.

Other 3-part properties (such as column-rule-color) highlight just fine, so it's not a parsing issue at least, but background-blend-mode just doesn't get the acceptance he desires. #foreveralone

@ficristo
Copy link
Collaborator

I tried with a empty test.css file and a .foo class.
Brackets highlights the background-blend-mode itself correctly and show the code hinting for the allowed values which aren't highlighted apart the values normal and overlay.
If I change the language to SCSS or LESS Brackets highlights the name itself correctly but do not shows the code hint for the values.
This was on master.

@torvalamo
Copy link
Author

Release 1.4 build 1.4.0-16380 (release 273804e)
build timestamp: Mon Jul 27 2015 07:23:52 GMT+0100

Oh, and for me it highlights correctly in LESS and SCSS but no code hint same as you. Still does not highlight in plain CSS, but shows code hint for property and values.

@ficristo
Copy link
Collaborator

I tried adding a foo property to CSSProperties.json with one value: bar.
The property were in the autocomplete but not the value.
Maybe the underline problem is the same?

/cc @marcelgerber @sprintr in the hope they know more 😄.

@sprintr
Copy link
Contributor

sprintr commented Dec 26, 2015

@ficristo It has to be defined in the codemirror's css mode. I'll put up a PR up there in a while. Should be in Brackets 1.7.

@sprintr
Copy link
Contributor

sprintr commented Dec 26, 2015

@ficristo @torvalamo The upstream PR is codemirror/codemirror5#3740

@ficristo
Copy link
Collaborator

@sprintr Thank you for looking into it!

@sprintr
Copy link
Contributor

sprintr commented Dec 28, 2015

@ficristo @torvalamo The fix for this has landed in CodeMirror.

@abose
Copy link
Contributor

abose commented Feb 1, 2016

Tracking to verify on CM update.

@ficristo
Copy link
Collaborator

ficristo commented May 3, 2016

Now that CodeMirror update has landed it is fixed. (I could not reproduce the problem of syntax highlighting on plain CSS, however on LESS, SCSS now the code hints come up correctly)
@abose @marcelgerber can we close this?

@marcelgerber
Copy link
Contributor

Thanks for the heads up!
Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants
@torvalamo @marcelgerber @sprintr @abose @ficristo and others