feat: support for virtual components #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new ComponentWrapper and added a new data-cq-resource-type attribute for virtual components
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 97.61% 97.71% +0.10%
==========================================
Files 13 13
Lines 293 306 +13
Branches 44 46 +2
==========================================
+ Hits 286 299 +13
Misses 7 7
Continue to review full report at Codecov.
|
* add a test
* update description of test
* fix failig tests
pfauchere
reviewed
Oct 13, 2020
pfauchere
reviewed
Oct 13, 2020
pfauchere
reviewed
Oct 13, 2020
CezCz
reviewed
Oct 14, 2020
* use better variable names
…/aem-react-editable-components into feature/virtual-components
* design changes * always have resourceType attribute * remove virtual thingy
* fix package.json
* update package-lock.json
* add test
* fix linting issues
* simplification
|
Kudos, SonarCloud Quality Gate passed!
|
CezCz
approved these changes
Oct 22, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2020
# [1.1.0](v1.0.6...v1.1.0) (2020-10-23) ### Features * support for virtual components ([#34](#34)) ([8839f97](8839f97))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR are -
withMappableget editProps()inEditableComponent.tsxDescription of the changes
Added a new
withMappableUtility to make a React component mappable and add the edition capabilities and model datawithEditorContext(withModel(withEditable...ComponentMapping.mapto use that as wellAdds a new
data-cq-resource-typeattribute on the component editable dom, when passed via the EditConfigAdded unit tests for the fix
Fixed linting issues.