Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upload content to AEM #11

Merged
merged 7 commits into from
Jan 8, 2025
Merged

feat: Upload content to AEM #11

merged 7 commits into from
Jan 8, 2025

Conversation

ManasMaji
Copy link
Member

  • Upload content package containing cq:Page(s)
  • Upload images using aem-upload
  • AEM credentials will be save in an encoded manner upon login.

Motivation and Context

For Xwalk, we need to upload the assets and cq:Pages created via the importer.

How Has This Been Tested?

  • Manually tested on using AEMaaCS dev env.
  • TODO : Add tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Upload content package containing cq:Page(s)
* Upload images using aem-upload
* AEM credentials will be save in an encoded manner upon login.
@ManasMaji ManasMaji marked this pull request as draft December 19, 2024 13:07
@bhellema bhellema requested review from blefebvre and arumsey and removed request for blefebvre December 19, 2024 13:29
@ManasMaji ManasMaji marked this pull request as ready for review January 7, 2025 04:25
@arumsey
Copy link
Contributor

arumsey commented Jan 7, 2025

Instead of two separate aem-* commands could you change it to have one aem command that then has wo sub login and upload commands?

Also, instead of an aem-uploader module just use aemso it matches the command name. You really don't need separate modules under the aem folder either since you only have three files and they are already have very descriptive names.

@ManasMaji
Copy link
Member Author

Hi @arumsey, thank you for the review. I have addressed your comments about having one aem cmd (with login and upload as sub cmds), and renamed the files and modules to be more concise.

Co-authored-by: Anthony Rumsey <arumsey@adobe.com>
Copy link
Contributor

@arumsey arumsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just delete 1aem-upload.js` if it is no longer needed.

@ManasMaji ManasMaji merged commit 6140cf1 into main Jan 8, 2025
2 checks passed
@bhellema bhellema deleted the aem-upload branch March 11, 2025 13:11
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
# 1.0.0 (2025-03-11)

### Bug Fixes

* Add unit test coverage ([#6](#6)) ([16b6146](16b6146))
* Figure out asset folder name from jcr image path ([#15](#15)) ([461292c](461292c))
* **sites-29589:** [Xwalk] aem-import-helper should take zip file and image mapping as args ([#20](#20)) ([2c1c615](2c1c615))
* **sites-29590:** support user bearer token ([#22](#22)) ([4d190b1](4d190b1))

### Features

* [Import Assistant] Page transformations ([#4](#4)) ([bfacdb0](bfacdb0))
* Implement standalone upload command ([72fd15d](72fd15d))
* Import Assistant ([#7](#7)) ([05e2082](05e2082))
* Initial implementation of SharePoint upload ([00eb93a](00eb93a))
* Initial implementation of SharePoint upload ([6cfc248](6cfc248))
* Initial implementation of SharePoint upload ([927d7eb](927d7eb))
* Initial implementation of SharePoint upload ([cc5a4b1](cc5a4b1))
* Show UI URL when job was created ([#13](#13)) ([04db418](04db418))
* SITES-27041 [Import Assistant] Remove system prompts from import builder ([#9](#9)) ([978a68d](978a68d))
* **sites-29400:** integrate xwalk support into aem-import-helper ([#17](#17)) ([e4e3afd](e4e3afd))
* **sites-29416:** [Xwalk] Add support for importing non-image assets ([#19](#19)) ([3c6c87d](3c6c87d))
* SITES-29655 Remove import assistant related code from the helper ([823c56a](823c56a))
* SITES-29655 Remove import assistant related code from the helper ([c3caac0](c3caac0))
* SITES-29655 Remove import assistant related code from the helper ([7f262e1](7f262e1))
* Upload content to AEM ([#11](#11)) ([6140cf1](6140cf1))
* Use multipart formdata to start a job ([#3](#3)) ([852d96d](852d96d))
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants