Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket now supports webhook secrets 🥳 #662

Open
peterwwillis opened this issue Nov 10, 2023 · 1 comment
Open

Bitbucket now supports webhook secrets 🥳 #662

peterwwillis opened this issue Nov 10, 2023 · 1 comment

Comments

@peterwwillis
Copy link

Bitbucket have finally decided to support secrets for webhooks: https://bitbucket.org/blog/enhanced-webhook-security

I'm not sure if there's code that needs updating, but these docs on Bitbucket could probably use updating: https://github.com/adnanh/webhook/blob/master/docs/Hook-Examples.md#incoming-bitbucket-webhook

Confusing matters is the fact that Bitbucket's X-Hub-Signature header is using a SHA256 hash, whereas both GitHub's and Facebook's X-Hub-Signature is SHA1, while their header X-Hub-Signature-256 is SHA256. You'd think after six years they'd want parity with other vendors... but better incompatible than unavailable, I guess 😐

@adnanh
Copy link
Owner

adnanh commented Nov 11, 2023

Better late than never, I guess 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants